From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Palmer Dabbelt <palmer@dabbelt.com>, tesheng@andestech.com
Cc: aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
peterx@redhat.com, penberg@kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
akpm@linux-foundation.org, walken@google.com,
linux-riscv@lists.infradead.org, vbabka@suse.cz
Subject: Re: [PATCH v3 0/2] Let illegal access to user-space memory die
Date: Mon, 1 Feb 2021 13:18:36 +0000 [thread overview]
Message-ID: <ee1f254d-a06e-9725-57d1-ce0210751c05@codethink.co.uk> (raw)
In-Reply-To: <mhng-607cbd62-adc5-45a7-adde-476741f9d63b@palmerdabbelt-glaptop>
On 22/12/2020 02:35, Palmer Dabbelt wrote:
> On Thu, 03 Dec 2020 21:42:57 PST (-0800), tesheng@andestech.com wrote:
>> Accesses to user-space memory without calling uaccess routine
>> leads to hanging in page fault handler. Like arm64, we let it
>> die earlier in page fault handler.
>>
>> Changes in v3:
>> -Let no_context() use die_kernel_fault() helper
>>
>> Changes in v2:
>> -Add a die_kernel_fault() helper
>> -Split one long line code into two
>>
>> Eric Lin (2):
>> riscv/mm: Introduce a die_kernel_fault() helper function
>> riscv/mm: Prevent kernel module to access user memory without uaccess
>> routines
>>
>> arch/riscv/mm/fault.c | 28 ++++++++++++++++++++++------
>> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> Thanks, these will be on for-next when the merge window ends.
Just tested this and it seems to be working.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
prev parent reply other threads:[~2021-02-01 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 5:42 [PATCH v3 0/2] Let illegal access to user-space memory die Eric Lin
2020-12-04 5:42 ` [PATCH v3 1/2] riscv/mm: Introduce a die_kernel_fault() helper function Eric Lin
2020-12-04 5:42 ` [PATCH v3 2/2] riscv/mm: Prevent kernel module to access user memory without uaccess routines Eric Lin
2020-12-22 2:35 ` [PATCH v3 0/2] Let illegal access to user-space memory die Palmer Dabbelt
2021-02-01 13:18 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee1f254d-a06e-9725-57d1-ce0210751c05@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=penberg@kernel.org \
--cc=peterx@redhat.com \
--cc=tesheng@andestech.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).