From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1952455AbdD3FWD (ORCPT ); Sun, 30 Apr 2017 01:22:03 -0400 Received: from huan3.mail.rambler.ru ([81.19.78.109]:28773 "EHLO huan3.mail.rambler.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427027AbdD3FVy (ORCPT ); Sun, 30 Apr 2017 01:21:54 -0400 Subject: Re: [PATCH 1/2] Add support for OneWire (W1) devices family 0x26 (MAX17211/MAX17215) To: Sebastian Reichel Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, zbr@ioremap.net References: <20170429143429.5685-1-minimumlaw@rambler.ru> <20170429143429.5685-2-minimumlaw@rambler.ru> <20170429155911.7li5torcliaoerxh@earth> From: "Alex A. Mihaylov" Message-ID: Date: Sun, 30 Apr 2017 08:21:51 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170429155911.7li5torcliaoerxh@earth> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: ru X-Rambler-User: minimumlaw@rambler.ru/178.70.112.37 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, >> Slave device provide software layer for access to internal registers >> MAX17211/MAX17215 chip. > Please convert this to regmap.There is no generic w1 handler, but you can provide custom > read/write functions. I think regmap be overkill for this driver. Here we need access to a small number of registers. Registers are extremely simple on the internal device. As a result, the software layer of regmap will only complicate the readability and understanding of the code. And also increase the size and time of code execution, and even complicate the perception. > Also it would be nice to have this > based on https://lkml.org/lkml/2017/3/16/604. Then everything > could go into the power-supply driver. > No problems. Once this set of patches will be accepted in the mainline. Alex.