From: Reinette Chatre <reinette.chatre@intel.com>
To: Dave Hansen <dave.hansen@intel.com>, <linux-sgx@vger.kernel.org>,
<jarkko@kernel.org>, <shuah@kernel.org>
Cc: <seanjc@google.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] selftests/sgx: Oversubscription, page permission, thread entry
Date: Thu, 16 Sep 2021 09:14:21 -0700 [thread overview]
Message-ID: <ee323912-ebb9-9262-a599-b7e22527f892@intel.com> (raw)
In-Reply-To: <c1f48aaa-5ab7-e44d-14ef-11c05a531d85@intel.com>
Hi Dave,
On 9/16/2021 8:37 AM, Dave Hansen wrote:
> On 9/15/21 1:30 PM, Reinette Chatre wrote:
>> This series consists out of outstanding SGX selftests changes, rebased
>> and gathered in a single series that is more easily merged for testing
>> and development, and a few more changes added to expand the existing tests.
>
> One other high-level thing we should probably mention: Building and
> running enclaves is a pain. It's traditionally required a big SDK from
> Intel or a big software stack from *somebody* else.
>
> This adds features like threads to the SGX selftest which are
> traditionally implemented in that big software stack. This is a *good*
> thing since it helps test SGX kernel support with only code from the
> kernel tree.
Will do. Just to be clear this support for multiple threads is essential
for exception handling testing. An exception that triggers an
asynchronous exit from an enclave could be fixed from outside the
enclave and then execution could return to the original thread, this is
demonstrated and tested in patch 12/14. Alternatively, it may be needed
to fix the issue that triggered the exception from _within_ the enclave.
In the latter case the enclave should be entered at a new entry point
(new thread/new Thread Control Structure(TCS)) from where the issue can
be fixed before execution can continue in the original thread that
triggered the exception. I have tests for this scenario.
> This is similar to what we did with MPX, which also typically required a
> big toolchain outside of the kernel. Despite MPX's demise, I think this
> approach worked well, and I'm happy to see it replicated here.
>
> Feel free to add my ack on the real (non-stub) patches in the series:
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
>
Thank you very much
Reinette
next prev parent reply other threads:[~2021-09-16 16:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:30 [PATCH 00/14] selftests/sgx: Oversubscription, page permission, thread entry Reinette Chatre
2021-09-15 20:30 ` [PATCH 01/14] selftests/x86/sgx: Fix a benign linker warning Reinette Chatre
2021-09-16 14:38 ` Jarkko Sakkinen
2021-09-16 14:39 ` Jarkko Sakkinen
2021-09-16 17:31 ` Reinette Chatre
2021-09-15 20:30 ` [PATCH 02/14] x86/sgx: Add /sys/kernel/debug/x86/sgx_total_mem Reinette Chatre
2021-09-16 14:09 ` Jarkko Sakkinen
2021-09-16 15:35 ` Reinette Chatre
2021-09-15 20:30 ` [PATCH 03/14] selftests/sgx: Assign source for each segment Reinette Chatre
2021-09-15 20:30 ` [PATCH 04/14] selftests/sgx: Make data measurement for an enclave segment optional Reinette Chatre
2021-09-15 20:30 ` [PATCH 05/14] selftests/sgx: Create a heap for the test enclave Reinette Chatre
2021-09-15 20:30 ` [PATCH 06/14] selftests/sgx: Dump segments and /proc/self/maps only on failure Reinette Chatre
2021-09-15 20:30 ` [PATCH 07/14] selftests/sgx: Encpsulate the test enclave creation Reinette Chatre
2021-09-15 20:30 ` [PATCH 08/14] selftests/sgx: Move setup_test_encl() to each TEST_F() Reinette Chatre
2021-09-15 20:30 ` [PATCH 09/14] selftests/sgx: Add a new kselftest: unclobbered_vdso_oversubscribed Reinette Chatre
2021-09-15 20:31 ` [PATCH 10/14] selftests/sgx: Provide per-op parameter structs for the test enclave Reinette Chatre
2021-09-15 20:31 ` [PATCH 11/14] selftests/sgx: Rename test properties in preparation for more enclave tests Reinette Chatre
2021-09-16 15:20 ` Jarkko Sakkinen
2021-09-15 20:31 ` [PATCH 12/14] selftests/sgx: Add page permission and exception test Reinette Chatre
2021-09-16 15:21 ` Jarkko Sakkinen
2021-09-16 15:37 ` Reinette Chatre
2021-09-16 15:30 ` Dave Hansen
2021-09-16 15:50 ` Reinette Chatre
2021-09-15 20:31 ` [PATCH 13/14] selftests/sgx: Enable multiple thread support Reinette Chatre
2021-09-16 15:23 ` Jarkko Sakkinen
2021-09-15 20:31 ` [PATCH 14/14] selftests/sgx: Add test for multiple TCS entry Reinette Chatre
2021-09-16 15:24 ` Jarkko Sakkinen
2021-09-16 14:13 ` [PATCH 00/14] selftests/sgx: Oversubscription, page permission, thread entry Jarkko Sakkinen
2021-09-16 15:37 ` Dave Hansen
2021-09-16 16:14 ` Reinette Chatre [this message]
2021-09-16 16:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee323912-ebb9-9262-a599-b7e22527f892@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).