From: Neil Armstrong <narmstrong@baylibre.com>
To: Nick Xie <xieqinick@gmail.com>
Cc: robh+dt@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Nick <nick@khadas.com>,
artem@khadas.com
Subject: Re: [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature
Date: Fri, 11 Jun 2021 09:15:13 +0200 [thread overview]
Message-ID: <ee3341d9-350e-a84d-6836-3401be679b2a@baylibre.com> (raw)
In-Reply-To: <CAP4nuTVMZV7pz8NrM2MHcZzBdueRXjS+KYsU4=cQ1CB67gr_Hg@mail.gmail.com>
Hi,
On 11/06/2021 08:54, Nick Xie wrote:
> Hello Neil,
>
> The MCU FAN won't work until the temperature reach to 80 degree centigrade,
> Do you think the temperature is too high?
I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.
Neil
>
> Thanks.
>
> Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>> 于2021年6月11日周五 下午2:44写道：
>
> Hi Nick,
>
> On 09/06/2021 03:28, xieqinick@gmail.com <mailto:xieqinick@gmail.com> wrote:
> > From: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
> >
> > Reduce the MCU FAN trigger temperature from
> > 80 degree centigrade to 50 degree centigrade.
>
> Can you add some more rationale to this change ?
>
> >
> > Signed-off-by: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> > index 66d67524b031..a9c34fee91f4 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> > @@ -256,7 +256,7 @@ &cecb_AO {
> > &cpu_thermal {
> > trips {
> > cpu_active: cpu-active {
> > - temperature = <80000>; /* millicelsius */
> > + temperature = <50000>; /* millicelsius */
> > hysteresis = <2000>; /* millicelsius */
> > type = "active";
> > };
> >
>
> With that:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>>
>
next prev parent reply other threads:[~2021-06-11 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 1:28 [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature xieqinick
2021-06-11 6:44 ` Neil Armstrong
[not found] ` <CAP4nuTVMZV7pz8NrM2MHcZzBdueRXjS+KYsU4=cQ1CB67gr_Hg@mail.gmail.com>
2021-06-11 7:15 ` Neil Armstrong [this message]
2021-06-11 7:30 ` Nick Xie
2021-06-11 7:45 ` Daniel Lezcano
2021-06-14 13:17 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3341d9-350e-a84d-6836-3401be679b2a@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=artem@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
--cc=xieqinick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).