From: David Lechner <david@lechnology.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"David S . Miller" <davem@davemloft.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Lukas Wunner <lukas@wunner.de>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Lunn <andrew@lunn.ch>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
netdev@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD
Date: Fri, 29 Jun 2018 15:35:27 -0500 [thread overview]
Message-ID: <ee49a8de-0812-a619-25be-4c6d8a35cc81@lechnology.com> (raw)
In-Reply-To: <e2579b81-7c66-8be6-fcad-ab7a3a5b0765@lechnology.com>
On 06/29/2018 03:09 PM, David Lechner wrote:
> On 06/29/2018 04:40 AM, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>
>> On da850-evm board we can read the MAC address from MTD. It's currently
>> done in the relevant board file, but we want to get rid of all the MAC
>> reading callbacks from the board file (SPI and NAND). Move the reading
>> of the MAC address from SPI to the emac driver's probe function.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> drivers/net/ethernet/ti/davinci_emac.c | 20 ++++++++++++++++++--
>> 1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
>> index a1a6445b5a7e..48e6a7755811 100644
>> --- a/drivers/net/ethernet/ti/davinci_emac.c
>> +++ b/drivers/net/ethernet/ti/davinci_emac.c
>> @@ -67,7 +67,7 @@
>> #include <linux/of_irq.h>
>> #include <linux/of_net.h>
>> #include <linux/mfd/syscon.h>
>> -
>> +#include <linux/mtd/mtd.h>
>> #include <asm/irq.h>
>> #include <asm/page.h>
>> @@ -1783,7 +1783,10 @@ static int davinci_emac_probe(struct platform_device *pdev)
>> struct cpdma_params dma_params;
>> struct clk *emac_clk;
>> unsigned long emac_bus_frequency;
>> -
>> +#ifdef CONFIG_MTD
>> + size_t mac_addr_len;
>> + struct mtd_info *mtd;
>> +#endif /* CONFIG_MTD */
>> /* obtain emac clock from kernel */
>> emac_clk = devm_clk_get(&pdev->dev, NULL);
>> @@ -1815,6 +1818,19 @@ static int davinci_emac_probe(struct platform_device *pdev)
>> goto err_free_netdev;
>> }
>> +#ifdef CONFIG_MTD
>
> What about the case when MTD is compiled as a module?
>
>> + mtd = get_mtd_device_nm("MAC-Address");
>
> What about the case when PTR_ERR(mtd) == -EPROBE_DEFER?
To answer my own question: because get_mtd_device_nm() doesn't
ever return -EPROBE_DEFER.
I'm trying to make this work on LCDK, but the emac driver probes
before any mtd device is registered, so, I just get -ENODEV even
though I've added a partition to the device tree labeled
"MAC-Address". You can see in the kernel messages that MTD is
not probed until later.
>
>> + if (!IS_ERR(mtd)) {
>> + rc = mtd_read(mtd, 0, ETH_ALEN,
>> + &mac_addr_len, priv->mac_addr);
>> + if (rc == 0)
>> + dev_info(&pdev->dev,
>> + "Read MAC addr from SPI Flash: %pM\n",
>> + priv->mac_addr);
>> + put_mtd_device(mtd);
>> + }
>> +#endif /* CONFIG_MTD */
>> +
>> /* MAC addr and PHY mask , RMII enable info from platform_data */
>> memcpy(priv->mac_addr, pdata->mac_addr, ETH_ALEN);
>> priv->phy_id = pdata->phy_id;
>>
>
next prev parent reply other threads:[~2018-06-29 20:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 9:40 [PATCH v4 00/18] ARM: davinci: step towards removing at24_platform_data Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 01/18] nvmem: add support for cell lookups Bartosz Golaszewski
2018-07-16 12:19 ` Srinivas Kandagatla
2018-07-16 12:20 ` Srinivas Kandagatla
2018-06-29 9:40 ` [PATCH v4 02/18] Documentation: nvmem: document lookup entries Bartosz Golaszewski
2018-07-16 12:14 ` Sekhar Nori
2018-07-16 12:18 ` Srinivas Kandagatla
2018-06-29 9:40 ` [PATCH v4 03/18] ARM: davinci: dm365-evm: use nvmem lookup for mac address Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 04/18] ARM: davinci: dm644-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 05/18] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 06/18] ARM: davinci: da830-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 07/18] ARM: davinci: mityomapl138: add nvmem cells lookup entries Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD Bartosz Golaszewski
2018-06-29 20:09 ` David Lechner
2018-06-29 20:35 ` David Lechner [this message]
2018-07-02 7:41 ` Bartosz Golaszewski
2018-07-03 16:39 ` Florian Fainelli
2018-07-03 16:47 ` David Lechner
2018-07-04 7:09 ` Ladislav Michl
2018-07-04 8:29 ` Bartosz Golaszewski
2018-07-04 9:04 ` Sekhar Nori
2018-07-13 18:00 ` Bartosz Golaszewski
2018-07-16 8:50 ` Sekhar Nori
2018-07-16 8:56 ` Srinivas Kandagatla
2018-07-16 11:57 ` Sekhar Nori
2018-07-16 12:10 ` Greg Kroah-Hartman
2018-07-16 12:13 ` Sekhar Nori
2018-07-20 5:04 ` Sekhar Nori
2018-07-27 9:52 ` Sekhar Nori
2018-06-29 9:40 ` [PATCH v4 09/18] ARM: davinci: da850-evm: remove dead MTD code Bartosz Golaszewski
2018-06-29 17:09 ` David Lechner
2018-07-02 7:28 ` Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 10/18] net: davinci_emac: use nvmem to retrieve the mac address Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 11/18] ARM: davinci: mityomapl138: don't read the MAC address from machine code Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 12/18] ARM: davinci: dm365-evm: use device properties for at24 eeprom Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 13/18] ARM: davinci: da830-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 14/18] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 15/18] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 16/18] ARM: davinci: sffsdr: fix the at24 eeprom device name Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 17/18] ARM: davinci: sffsdr: use device properties for at24 eeprom Bartosz Golaszewski
2018-06-29 9:40 ` [PATCH v4 18/18] ARM: davinci: remove dead code related to MAC address reading Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee49a8de-0812-a619-25be-4c6d8a35cc81@lechnology.com \
--to=david@lechnology.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).