From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Pankaj Gupta <pankaj.gupta.linux@gmail.com>, song@kernel.org
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Subject: Re: [PATCH 1/3] md: improve variable names in md_flush_request()
Date: Wed, 11 Nov 2020 07:52:01 +0100 [thread overview]
Message-ID: <ee573db1-33d0-b210-7205-4736de007488@molgen.mpg.de> (raw)
In-Reply-To: <20201111051658.18904-2-pankaj.gupta.linux@gmail.com>
Dear Pankaj,
Thank you for the cleanups.
Am 11.11.20 um 06:16 schrieb Pankaj Gupta:
> From: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
>
> This patch improves readability by using better variable names
> in flush request coalescing logic.
Please do not indent the commit message.
> Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> ---
> drivers/md/md.c | 8 ++++----
> drivers/md/md.h | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 98bac4f304ae..167c80f98533 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -639,7 +639,7 @@ static void md_submit_flush_data(struct work_struct *ws)
> * could wait for this and below md_handle_request could wait for those
> * bios because of suspend check
> */
> - mddev->last_flush = mddev->start_flush;
> + mddev->prev_flush_start = mddev->start_flush;
> mddev->flush_bio = NULL;
> wake_up(&mddev->sb_wait);
>
> @@ -660,13 +660,13 @@ static void md_submit_flush_data(struct work_struct *ws)
> */
> bool md_flush_request(struct mddev *mddev, struct bio *bio)
> {
> - ktime_t start = ktime_get_boottime();
> + ktime_t req_start = ktime_get_boottime();
> spin_lock_irq(&mddev->lock);
> wait_event_lock_irq(mddev->sb_wait,
> !mddev->flush_bio ||
> - ktime_after(mddev->last_flush, start),
> + ktime_after(mddev->prev_flush_start, req_start),
> mddev->lock);
> - if (!ktime_after(mddev->last_flush, start)) {
> + if (!ktime_after(mddev->prev_flush_start, req_start)) {
> WARN_ON(mddev->flush_bio);
> mddev->flush_bio = bio;
> bio = NULL;
> diff --git a/drivers/md/md.h b/drivers/md/md.h
> index ccfb69868c2e..2292c847f9dd 100644
> --- a/drivers/md/md.h
> +++ b/drivers/md/md.h
> @@ -495,9 +495,9 @@ struct mddev {
> */
> struct bio *flush_bio;
> atomic_t flush_pending;
> - ktime_t start_flush, last_flush; /* last_flush is when the last completed
> - * flush was started.
> - */
> + ktime_t start_flush, prev_flush_start; /* prev_flush_start is when the previous completed
> + * flush was started.
> + */
With the new variable name, the comment could even be removed. ;-)
> struct work_struct flush_work;
> struct work_struct event_work; /* used by dm to report failure event */
> mempool_t *serial_info_pool;
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
next prev parent reply other threads:[~2020-11-11 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 5:16 [PATCH 0/3] md: code cleanups Pankaj Gupta
2020-11-11 5:16 ` [PATCH 1/3] md: improve variable names in md_flush_request() Pankaj Gupta
2020-11-11 6:52 ` Paul Menzel [this message]
2020-11-11 7:22 ` Pankaj Gupta
2020-11-11 5:16 ` [PATCH 2/3] md: add comments " Pankaj Gupta
2020-11-11 5:16 ` [PATCH 3/3] md: use current request time as base for ktime comparisons Pankaj Gupta
2020-11-16 17:30 ` [PATCH 0/3] md: code cleanups Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee573db1-33d0-b210-7205-4736de007488@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pankaj.gupta@cloud.ionos.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).