From: Jaehoon Chung <jh80.chung@samsung.com>
To: John Keeping <john@metanate.com>, linux-mmc@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/4] mmc: dw_mmc: add common capabilities to replace caps
Date: Fri, 26 Nov 2021 08:37:01 +0900 [thread overview]
Message-ID: <ee596652-68f8-ddd4-4dcd-1bdb3a8a056b@samsung.com> (raw)
In-Reply-To: <20211124184603.3897245-2-john@metanate.com>
On 11/25/21 3:45 AM, John Keeping wrote:
> The caps field depends on the mshcN alias ID but for some devices this
> is unnecessary as the capabilities are the same for all instances
> sharing the same compatible.
>
> Add a common_caps field for this case which updates the host's
> capabilities without needing the mshcN alias ID.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/host/dw_mmc.c | 3 +++
> drivers/mmc/host/dw_mmc.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 195f2b2434b0..f2a14a434bef 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2856,6 +2856,9 @@ static int dw_mci_init_slot_caps(struct dw_mci_slot *slot)
> if (host->pdata->pm_caps)
> mmc->pm_caps = host->pdata->pm_caps;
>
> + if (drv_data)
> + mmc->caps |= drv_data->common_caps;
> +
> if (host->dev->of_node) {
> ctrl_id = of_alias_get_id(host->dev->of_node, "mshc");
> if (ctrl_id < 0)
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index ce05d81477d9..771d5afa3136 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -550,6 +550,8 @@ struct dw_mci_slot {
> * dw_mci driver data - dw-mshc implementation specific driver data.
> * @caps: mmc subsystem specified capabilities of the controller(s).
> * @num_caps: number of capabilities specified by @caps.
> + * @common_caps: mmc subsystem specified capabilities applicable to all of
> + * the controllers
> * @init: early implementation specific initialization.
> * @set_ios: handle bus specific extensions.
> * @parse_dt: parse implementation specific device tree properties.
> @@ -562,6 +564,7 @@ struct dw_mci_slot {
> struct dw_mci_drv_data {
> unsigned long *caps;
> u32 num_caps;
> + u32 common_caps;
> int (*init)(struct dw_mci *host);
> void (*set_ios)(struct dw_mci *host, struct mmc_ios *ios);
> int (*parse_dt)(struct dw_mci *host);
>
next prev parent reply other threads:[~2021-11-25 23:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 18:45 [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases John Keeping
2021-11-24 18:45 ` [PATCH 1/4] mmc: dw_mmc: add common capabilities to replace caps John Keeping
2021-11-25 23:37 ` Jaehoon Chung [this message]
2021-11-24 18:46 ` [PATCH 2/4] mmc: dw_mmc: hi3798cv200: use common_caps John Keeping
2021-11-25 23:37 ` Jaehoon Chung
2021-11-24 18:46 ` [PATCH 3/4] mmc: dw_mmc: rockchip: " John Keeping
2021-11-25 23:37 ` Jaehoon Chung
2021-11-24 18:46 ` [PATCH 4/4] mmc: dw_mmc: exynos: " John Keeping
2021-11-25 23:38 ` Jaehoon Chung
2021-11-26 12:39 ` John Keeping
2021-11-24 19:24 ` [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases Ulf Hansson
2021-11-26 13:31 ` Ulf Hansson
2021-11-25 11:48 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee596652-68f8-ddd4-4dcd-1bdb3a8a056b@samsung.com \
--to=jh80.chung@samsung.com \
--cc=heiko@sntech.de \
--cc=john@metanate.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).