From: Laura Abbott <labbott@redhat.com>
To: Abishek V Ashok <abishekvashok@gmail.com>,
gregkh@linuxfoundation.org, sumit.semwal@linaro.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c
Date: Thu, 24 Aug 2017 08:55:49 -0700 [thread overview]
Message-ID: <ee794dae-e638-69c1-3ea2-2953ab84c937@redhat.com> (raw)
In-Reply-To: <20170824154050.11345-1-abishekvashok@gmail.com>
On 08/24/2017 08:40 AM, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
>
You've done two things in this patch, please stick to a single
change per patch.
> Signed-off-by: Abhishek V Ashok <abishekvashok@gmail.com>
> ---
> drivers/staging/android/ion/ion_cma_heap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index a0949bc0..1589b9e0 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -31,7 +31,6 @@ struct ion_cma_heap {
>
> #define to_cma_heap(x) container_of(x, struct ion_cma_heap, heap)
>
> -
> /* ION CMA heap operations functions */
> static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
> unsigned long len,
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
> if (!pages)
> return -ENOMEM;
>
> - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> + table = kmalloc(sizeof(struct * table), GFP_KERNEL);
> if (!table)
> goto err;
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-08-24 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 15:40 [PATCH] Staging: Android: fix code style in ion_cma_heap.c Abishek V Ashok
2017-08-24 15:55 ` Laura Abbott [this message]
2017-08-24 19:07 ` Dan Carpenter
2017-08-24 20:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee794dae-e638-69c1-3ea2-2953ab84c937@redhat.com \
--to=labbott@redhat.com \
--cc=abishekvashok@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).