linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, tglx@linutronix.de
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] genirq/affinity: Introduce struct irq_affinity
Date: Tue, 8 Nov 2016 09:11:56 +0100	[thread overview]
Message-ID: <ee7ee373-5048-4e62-3f58-4e1e74edf7e5@suse.de> (raw)
In-Reply-To: <1478544462-9549-2-git-send-email-hch@lst.de>

On 11/07/2016 07:47 PM, Christoph Hellwig wrote:
> From: Christogh Hellwig <hch@lst.de>
>
> Some drivers (various network and RDMA adapter for example) have a MSI-X
> vector layout where most of the vectors are used for I/O queues and should
> have CPU affinity assigned to them, but some (usually 1 but sometimes more)
> at the beginning or end are used for low-performance admin or configuration
> work and should not have any explicit affinity assigned to them.
>
> This adds a new irq_affinity structure, which will be passed through a
> variant of pci_irq_alloc_vectors that allows to specify these
> requirements (and is extensible to any future quirks in that area) so that
> the core IRQ affinity algorithm can take this quirks into account.
>
> Signed-off-by: Christogh Hellwig <hch@lst.de>
> ---
>  include/linux/interrupt.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 72f0721..7284bcd 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -232,6 +232,18 @@ struct irq_affinity_notify {
>  	void (*release)(struct kref *ref);
>  };
>
> +/**
> + * struct irq_affinity - Description for auto irq affinity assignements
> + * @pre_vectors:	Reserved vectors at the beginning of the MSIX
> + *			vector space
> + * @post_vectors:	Reserved vectors at the end of the MSIX
> + *			vector space
> + */
> +struct irq_affinity {
> +	int	pre_vectors;
> +	int	post_vectors;
> +};
> +
>  #if defined(CONFIG_SMP)
>
>  extern cpumask_var_t irq_default_affinity;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2016-11-08  8:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 18:47 support for partial irq affinity assignment Christoph Hellwig
2016-11-07 18:47 ` [PATCH 1/7] genirq/affinity: Introduce struct irq_affinity Christoph Hellwig
2016-11-08  8:11   ` Hannes Reinecke [this message]
2016-11-08  8:19   ` Johannes Thumshirn
2016-11-08 21:25   ` Bjorn Helgaas
2016-11-08 22:30     ` Christoph Hellwig
2016-11-07 18:47 ` [PATCH 2/7] genirq/affinity: Handle pre/post vectors in irq_calc_affinity_vectors() Christoph Hellwig
2016-11-08  8:14   ` Hannes Reinecke
2016-11-08 14:40     ` Thomas Gleixner
2016-11-07 18:47 ` [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks() Christoph Hellwig
2016-11-08  8:15   ` Hannes Reinecke
2016-11-08 14:55     ` Christoph Hellwig
2016-11-08 14:59       ` Hannes Reinecke
2016-11-08 15:00         ` Christoph Hellwig
2016-11-08 16:27           ` Thomas Gleixner
2016-11-08 16:33             ` Christoph Hellwig
2016-11-08 21:20   ` Bjorn Helgaas
2016-11-07 18:47 ` [PATCH 4/7] pci/msi: Propagate irq affinity description through the MSI code Christoph Hellwig
2016-11-08  8:16   ` Hannes Reinecke
2016-11-08  8:24   ` Johannes Thumshirn
2016-11-08 21:18   ` Bjorn Helgaas
2016-11-07 18:47 ` [PATCH 5/7] pci/msi: Provide pci_alloc_irq_vectors_affinity() Christoph Hellwig
2016-11-08  8:17   ` Hannes Reinecke
2016-11-08  8:27     ` Johannes Thumshirn
2016-11-08 21:17   ` Bjorn Helgaas
2016-11-08 21:20     ` Christoph Hellwig
2016-11-07 18:47 ` [PATCH 6/7] pci: Remove the irq_affinity mask from struct pci_dev Christoph Hellwig
2016-11-08  8:17   ` Hannes Reinecke
2016-11-08  8:27   ` Johannes Thumshirn
2016-11-08 20:59   ` Bjorn Helgaas
2016-11-07 18:47 ` [PATCH 7/7] blk-mq: add a first_vec argument to blk_mq_pci_map_queues Christoph Hellwig
2016-11-08  8:27   ` Johannes Thumshirn
2016-11-09  1:15 support for partial irq affinity assignment V3 Christoph Hellwig
2016-11-09  1:15 ` [PATCH 1/7] genirq/affinity: Introduce struct irq_affinity Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee7ee373-5048-4e62-3f58-4e1e74edf7e5@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).