From: "Ravi Kumar Bokka (Temp)" <rbokka@codeaurora.org>
To: Douglas Anderson <dianders@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: evgreen@chromium.org, dhavalp@codeaurora.org,
mturney@codeaurora.org, sparate@codeaurora.org,
rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: Enforce nvmem stride in the sysfs interface
Date: Fri, 29 May 2020 16:18:11 +0530 [thread overview]
Message-ID: <ee900df1-0df7-7e73-1916-531dbc5e243b@codeaurora.org> (raw)
In-Reply-To: <20200528165250.1.Iad7dec5afecba175c816773a0088be805476453f@changeid>
Hi,
On 5/29/2020 5:23 AM, Douglas Anderson wrote:
> The 'struct nvmem_config' has a stride attribute that specifies the
> needed alignment for accesses into the nvmem. This is used in
> nvmem_cell_info_to_nvmem_cell() but not in the sysfs read/write
> functions. If the alignment is important in one place it's important
> everywhere, so let's add enforcement.
>
> For now we'll consider it totally invalid to access with the wrong
> alignment. We could relax this in the read case where we could just
> read some extra bytes and throw them away. Relaxing it in the write
> case seems harder (and less safe?) since we'd have to read some data
> first and then write it back. To keep it symmetric we'll just
> disallow it in both cases.
>
> Reported-by: Ravi Kumar Bokka <rbokka@codeaurora.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/nvmem/core.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
I have reviewed and tested this patch.
Result: kernel crash resolved with unaligned offset.
Reviewed-by: Ravi Kumar Bokka <rbokka@codeaurora.org>
Tested-by: Ravi Kumar Bokka <rbokka@codeaurora.org>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 05c6ae4b0b97..1c0e7953f90d 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -111,6 +111,9 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,
> if (pos >= nvmem->size)
> return 0;
>
> + if (!IS_ALIGNED(pos, nvmem->stride))
> + return -EINVAL;
> +
> if (count < nvmem->word_size)
> return -EINVAL;
>
> @@ -148,6 +151,9 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
> if (pos >= nvmem->size)
> return -EFBIG;
>
> + if (!IS_ALIGNED(pos, nvmem->stride))
> + return -EINVAL;
> +
> if (count < nvmem->word_size)
> return -EINVAL;
>
>
Regards,
Ravi Kumar.B
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by the Linux Foundation.
next prev parent reply other threads:[~2020-05-29 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 23:53 [PATCH] nvmem: Enforce nvmem stride in the sysfs interface Douglas Anderson
2020-05-29 10:48 ` Ravi Kumar Bokka (Temp) [this message]
2020-06-01 8:56 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee900df1-0df7-7e73-1916-531dbc5e243b@codeaurora.org \
--to=rbokka@codeaurora.org \
--cc=dhavalp@codeaurora.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturney@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sparate@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).