From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Simon Horman <horms@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del_deffered operations
Date: Sat, 09 Mar 2024 09:14:50 -0800 [thread overview]
Message-ID: <eeabbfd72b3c3a354838e889ee6602774e67cbef.camel@perches.com> (raw)
In-Reply-To: <20240309090931.16d8d58a@hermes.local>
On Sat, 2024-03-09 at 09:09 -0800, Stephen Hemminger wrote:
> On Sat, 09 Mar 2024 06:26:28 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > > + problem = "Attempted operation is undefined, indicating a "
> > > + "possible programming error.\n";
> >
> > My preference would be to write
> > problem = "Attempted operation is undefined indicating a possible programming error\n";
>
> ETOOWORDY.
> Be concise please.
> problem = "Operations is undefined\n";
>
Concision is good, plurality matching is too.
prev parent reply other threads:[~2024-03-09 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 10:47 [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del_deffered operations Oleksij Rempel
2024-03-09 4:02 ` Jakub Kicinski
2024-03-09 14:26 ` Joe Perches
2024-03-09 17:09 ` Stephen Hemminger
2024-03-09 17:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeabbfd72b3c3a354838e889ee6602774e67cbef.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).