linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: carsten.haitzler@foss.arm.com, linux-kernel@vger.kernel.org
Cc: coresight@lists.linaro.org, suzuki.poulose@arm.com,
	mathieu.poirier@linaro.org, mike.leach@linaro.org,
	leo.yan@linaro.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Subject: Re: A patch series improving data quality of perf test for CoreSight
Date: Tue, 19 Jul 2022 10:07:22 +0100	[thread overview]
Message-ID: <eeec10a3-e9e7-ba7f-34e0-cded9d4af76e@arm.com> (raw)
In-Reply-To: <20220712135750.2212005-1-carsten.haitzler@foss.arm.com>



On 12/07/2022 14:57, carsten.haitzler@foss.arm.com wrote:
> This is a prelude to adding more tests to shell tests and in order to
> support putting those tests into subdirectories, I need to change the
> test code that scans/finds and runs them.
> 
> To support subdirs I have to recurse so it's time to refactor the code to
> allow this and centralize the shell script finding into one location and
> only one single scan that builds a list of all the found tests in memory
> instead of it being duplicated in 3 places.
> 
> This code also optimizes things like knowing the max width of desciption
> strings (as we can do that while we scan instead of a whole new pass
> of opening files). It also more cleanly filters scripts to see only
> *.sh files thus skipping random other files in directories like *~
> backup files, other random junk/data files that may appear and the
> scripts must be executable to make the cut (this ensures the script
> lib dir is not seen as scripts to run). This avoids perf test running
> previous older versions of test scripts that are editor backup files
> as well as skipping perf.data files that may appear and so on.
> 
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> 
> 

Hi Carsten,

What's the plan to move forward with the current test failures? As you
said in the previous patchset it seems that we're not 100% sure if the
failures are a Coresight bug or a test bug.

Do you want to investigate to see what the issue might be? Or do you
intend to leave that to someone else?

Even if it is a Coresight bug rather than a test bug, we shouldn't
merge them because it will cause anyone running the tests to wonder if
they have done something wrong or to duplicate the investigation work,
or that a regression has been added to the kernel.

Thanks
James

      parent reply	other threads:[~2022-07-19  9:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 13:57 A patch series improving data quality of perf test for CoreSight carsten.haitzler
2022-07-12 13:57 ` [PATCH 01/14] perf test: Refactor shell tests allowing subdirs carsten.haitzler
2022-07-13  6:53   ` Leo Yan
2022-07-13  6:58     ` Leo Yan
2022-07-12 13:57 ` [PATCH 02/14] perf test: Add CoreSight shell lib shared code for future tests carsten.haitzler
2022-07-13  7:23   ` Leo Yan
2022-07-13 12:49   ` Mike Leach
2022-07-12 13:57 ` [PATCH 03/14] perf test: Add build infra for perf test tools for CoreSight tests carsten.haitzler
2022-07-12 13:57 ` [PATCH 04/14] perf test: Add asm pureloop test tool carsten.haitzler
2022-07-12 13:57 ` [PATCH 05/14] perf test: Add asm pureloop test shell script carsten.haitzler
2022-07-12 13:57 ` [PATCH 06/14] perf test: Add git ignore for perf data generated by the CoreSight tests carsten.haitzler
2022-07-12 13:57 ` [PATCH 07/14] perf test: Add memcpy thread test tool carsten.haitzler
2022-07-12 13:57 ` [PATCH 08/14] perf test: Add memcpy thread test shell script carsten.haitzler
2022-07-12 13:57 ` [PATCH 09/14] perf test: Add thread loop test tool carsten.haitzler
2022-07-12 13:57 ` [PATCH 10/14] perf test: Add thread loop test shell scripts carsten.haitzler
2022-07-12 13:57 ` [PATCH 11/14] perf test: Add unroll thread test tool carsten.haitzler
2022-07-12 13:57 ` [PATCH 12/14] perf test: Add unroll thread test shell script carsten.haitzler
2022-07-12 13:57 ` [PATCH 13/14] perf test: Add git ignore for tmp and output files of CoreSight tests carsten.haitzler
2022-07-12 13:57 ` [PATCH 14/14] perf test: Add relevant documentation about CoreSight testing carsten.haitzler
2022-07-13  5:23 ` A patch series improving data quality of perf test for CoreSight Leo Yan
2022-07-13  8:14 ` Suzuki K Poulose
2022-07-19  9:07 ` James Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeec10a3-e9e7-ba7f-34e0-cded9d4af76e@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=carsten.haitzler@foss.arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).