From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534FDC433EF for ; Thu, 16 Sep 2021 14:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2931361246 for ; Thu, 16 Sep 2021 14:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238118AbhIPOFL (ORCPT ); Thu, 16 Sep 2021 10:05:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36294 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235536AbhIPOFJ (ORCPT ); Thu, 16 Sep 2021 10:05:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631801028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InkSSQy+zkt1/Sq2nJaTJOAqUI+Qk6BMdAVU8hoiD9c=; b=JzpCOuhTM7msh1MensiJ3xLj8cQEmy9n7jp5Ef7WdTgfDLqLmKqE7AkjJYGM+a/FKXvXwR roBEK/b0whzny3FJLJ9OUfPGS6iqUePYo+5nKoTXCumAz/jCRYxKJkF4bgx/P1vR3pMYmu jgqACkIpn9iGeClf44L4cQZ3PZMddT4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-MV3rGsXlNKGbM03oOltzEw-1; Thu, 16 Sep 2021 10:03:46 -0400 X-MC-Unique: MV3rGsXlNKGbM03oOltzEw-1 Received: by mail-wr1-f71.google.com with SMTP id r9-20020a5d4989000000b0015d0fbb8823so2457277wrq.18 for ; Thu, 16 Sep 2021 07:03:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=InkSSQy+zkt1/Sq2nJaTJOAqUI+Qk6BMdAVU8hoiD9c=; b=Ga23tSImJpVzG4+yyGvp7Xky4CLadsj08P1Eqv8b5CsjKitYPKRJJJvtU47wKHkqLF /2iN0Xj1f69Fl84MR/xjYh8FdDCXMBKUlUVBUSId+VEaPy0TZsf5DCq4R0vnchci4FbT DaXcfpwy5LXFFapqjYIP15ruDvIf+xp6cxh9K5SRSVST7ExsJYDYlnyD1kG5NUKVF3Wq BZwRi3AbhV8eHQiQa1hnyJ9hilEsscKCpzNqGvas7/xSFkNehsUqlmPr8tnubuaquVYx 3kCmOHAtEXJkxlol9le3rWSQpw4kiLtXjLj0G/sQTR9WEZs0+G81EDCFzdKemj2F8CeU awRA== X-Gm-Message-State: AOAM532H4XnLwPcZIn5UO6qsNrXuxbK0pmeYY7qeKF+L7WClbGVDs9X3 1ZF0rxD0vqJ5RQdLb44iVl3V7fl+obo6pr5qaF3DHAyWEs6IQarJhrBff5z2MKJ/jYhkmFG3zml hmKTwKu/msjw6GQp3YOGXzgNF X-Received: by 2002:adf:e74b:: with SMTP id c11mr6371112wrn.101.1631801025692; Thu, 16 Sep 2021 07:03:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/lhk0vbwJSHMlHYygHpizbHLXpjbz403gb1bSwePYyjBwbWX/UNKyVaKVGPdD3tXAKLjHow== X-Received: by 2002:adf:e74b:: with SMTP id c11mr6371074wrn.101.1631801025407; Thu, 16 Sep 2021 07:03:45 -0700 (PDT) Received: from [192.168.3.132] (p4ff23828.dip0.t-ipconnect.de. [79.242.56.40]) by smtp.gmail.com with ESMTPSA id s15sm3612858wrb.22.2021.09.16.07.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 07:03:44 -0700 (PDT) Subject: Re: [PATCH v4 1/1] s390x: KVM: accept STSI for CPU topology information To: Pierre Morel , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com, thuth@redhat.com, imbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com References: <1631799845-24860-1-git-send-email-pmorel@linux.ibm.com> <1631799845-24860-2-git-send-email-pmorel@linux.ibm.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 16 Sep 2021 16:03:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1631799845-24860-2-git-send-email-pmorel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > struct kvm_vm_stat { > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 51d1594bd6cd..f3887e13c5db 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -608,6 +608,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > case KVM_CAP_S390_PROTECTED: > r = is_prot_virt_host(); > break; > + case KVM_CAP_S390_CPU_TOPOLOGY: > + r = test_facility(11); > + break; > default: > r = 0; > } > @@ -819,6 +822,19 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap) > icpt_operexc_on_all_vcpus(kvm); > r = 0; > break; > + case KVM_CAP_S390_CPU_TOPOLOGY: As given in my example, this should be r = -EINVAL; mutex_lock(&kvm->lock); if (kvm->created_vcpus) { r = -EBUSY; } else if (test_facility(11)) { ... } Similar to how we handle KVM_CAP_S390_VECTOR_REGISTERS. [...] > + > + /* PTF needs both host and guest facilities to enable interpretation */ > + if (test_kvm_facility(vcpu->kvm, 11) && test_facility(11)) > + vcpu->arch.sie_block->ecb |= ECB_PTF; This should be simplified to if (test_kvm_facility(vcpu->kvm, 11)) then. (vsie code below is correct) -- Thanks, David / dhildenb