From: Andrej Picej <andrej.picej@norik.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: Support Opensource <Support.Opensource@diasemi.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode
Date: Wed, 1 Dec 2021 07:42:44 +0100 [thread overview]
Message-ID: <ef3f98e1-6661-84ed-1bde-747b1330aba2@norik.com> (raw)
In-Reply-To: <DB9PR10MB46521F419F43685F7103D32480679@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
On 30. 11. 21 18:46, Adam Thomson wrote:
> On 30 November 2021 16:40, Guenter Roeck wrote:
>
>>>> Why does it need a value ? Why not just bool ?
>>>
>>> One argument might be that if the property isn't provided then the OTP
>>> configured value can persist without needing a FW change around this DT
>> binding.
>>>
>>> My belief though is that the majority of users would have this property set to 0
>>> by default in OTP, so a boolean would be OK I think here to enable watchdog
>>> shutdown.
>>>
>>
>> Sorry, you lost me.
>> dlg,wdt-sd = <0>;
>> is the current situation, and identical to not having the property in
>> the first place.
>> dlg,wdt-sd = <1>;
>> is new. I don't see the difference to
>> dlg,wdt-sd;
>> vs. not having the property at all (which is, again, the current situation).
>> Since it has to be backward compatible,
>> dlg,wdt-sd = <0>;
>> will always be identical to not having the property at all.
>> I can not find a situation where an integer would have any benefits over a
>> boolean.
>
> So if you have a binary DT binding, it's either there or it isn't which implies
> the bit to be set to 0/1 in this case. If you have a binding which has a value,
> there can be 3 outcomes in this discussion:
>
> 1) Binding = 0, bit is set to 0
> 2) Binding = 1, bit is set to 1
> 3) Binding NOT present in DT, OTP default value in HW remains untouched
>
> Say a platform updates to a later kernel version, but sticks with existing DT
> FW (i.e. the new boolean binding isn't present in FW), then the following could
> happen:
>
> 1) OTP for DA9061/2 has this bit set to 1, system expectation is that watchdog
> triggers SHUTDOWN.
> 2) New driver checks existance of 'dlg,wdt-sd' but it's obviously not there so
> assumes the bit should be set to 0 and does so
> 3) When the watchdog fires, it will no longer trigger SHUTDOWN but instead
> POWER-DOWN due to binary handling of new boolean binding.
>
This was my thinking exactly. I also first thought about boolean value,
but I then moved to the integer value of 0 or 1 after checking the OTP
default for this bit. The da9062 I'm working with has the bit set to 1
by default.
next prev parent reply other threads:[~2021-12-01 6:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 13:42 [PATCH v2 1/4] mfd: da9062: make register CONFIG_I writable Andrej Picej
2021-11-30 13:42 ` [PATCH v2 2/4] watchdog: da9062: reset board on watchdog timeout Andrej Picej
2021-11-30 13:54 ` Andrej Picej
2021-11-30 13:42 ` [PATCH v2 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode Andrej Picej
2021-11-30 13:54 ` Andrej Picej
2021-11-30 14:32 ` Guenter Roeck
2021-11-30 16:11 ` Adam Thomson
2021-11-30 16:40 ` Guenter Roeck
2021-11-30 17:46 ` Adam Thomson
2021-12-01 6:42 ` Andrej Picej [this message]
2021-12-01 7:01 ` Guenter Roeck
2021-12-01 7:05 ` Andrej Picej
2021-11-30 13:42 ` [PATCH v2 4/4] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Andrej Picej
2021-11-30 13:56 ` Andrej Picej
2021-11-30 14:31 ` Guenter Roeck
2021-11-30 13:49 ` [PATCH v2 1/4] mfd: da9062: make register CONFIG_I writable Andrej Picej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef3f98e1-6661-84ed-1bde-747b1330aba2@norik.com \
--to=andrej.picej@norik.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).