From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933183AbeALCWd (ORCPT + 1 other); Thu, 11 Jan 2018 21:22:33 -0500 Received: from mga01.intel.com ([192.55.52.88]:28835 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932538AbeALCWc (ORCPT ); Thu, 11 Jan 2018 21:22:32 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="8997202" Subject: Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1515668586-14327-1-git-send-email-yao.jin@linux.intel.com> <20180111153028.GB20406@krava> From: "Jin, Yao" Message-ID: Date: Fri, 12 Jan 2018 10:22:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180111153028.GB20406@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/11/2018 11:30 PM, Jiri Olsa wrote: > On Thu, Jan 11, 2018 at 07:03:06PM +0800, Jin Yao wrote: >> We keep having bug reports that when users build perf on their own, > > we already have same warnings during the build > Yes, there will be warnings displayed during the build if some libraries are missing. While I do find the users (especially the new perf user) don't notice the warning. They only care about the success of build. Once they use this perf version and find something working strangely, they will say that perf may have bug. :( >> but they don't install some needed libraries like libelf, libbfd/libibery. > > how about saying that in the symbol column, > instead of poluting report's output, like: > > $ perf report --stdio > > # Overhead Command Shared Object Symbol (disabled) > # ........ ....... ................ ...................... > I just think it'd better provide some hints to user. For example, "symbol is disabled and you need to install libelf/xxx", say something like that. But it looks the column can't contain too much information (i.e. no more space to contain the entire hints). Any idea? Or just add this warning in verbose mode? > also your change does not affect tui mode > > annotation for some reason does not start at all.. could be > little more verbose ;-) > > jirka > Yes, it doesn't affect tui mode. Or we just add this warning in verbose mode? e.g. perf report -v? Thanks Jin Yao