From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A43EC4320A for ; Thu, 2 Sep 2021 07:22:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 477046108B for ; Thu, 2 Sep 2021 07:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbhIBHXN (ORCPT ); Thu, 2 Sep 2021 03:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243112AbhIBHXL (ORCPT ); Thu, 2 Sep 2021 03:23:11 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8439DC061757 for ; Thu, 2 Sep 2021 00:22:13 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id u9so1274595wrg.8 for ; Thu, 02 Sep 2021 00:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=reply-to:subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2Sr4JglvdWDBQ2wOTZW6ElZD1OAh7p+s3FJK89qhgiM=; b=FS94AIis1HaeP4YWFLvWShRs7pOBIvYRjx0VLv6hM9zDKmreAzv5G5CfG8A6iX29W2 01ozlnfm6paVlRWetFTsY9E/v+GNNLRVtSwNwt1mJymNKqlW8N7jcS7fMQauEzG2D16y +KgcW68JBohppxrdZB/0JOBdxCrW37YMLzm5SjbdSM5R/I3Zo92O9HGMlOA4+ncodUog Q884MiVIxhIPuj45jbj554K1MyQkbm4SWLhGU6/7FLQ48yZJbASmWaXZLNCl4VST96iD Dcjumy9O6saBzIuzqZIjRA60ReyVtHuT5NtvxMHmzpJ1x39HljOu3SzB7h3BI0Dqto89 Pf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2Sr4JglvdWDBQ2wOTZW6ElZD1OAh7p+s3FJK89qhgiM=; b=gboSwEs0RXMUqAnlaWCns0hwvaDSvUWjyVs+hmwsrK3uTh/EjxycJ0EF9P9QcJGup5 jl9cja6R3F7eGsxqzfs6pQudfmeZ9tTYNltKfCRkI+/eTuVWeZbQoYLJFDvsswzzgy6P ApWpAKLF5HOXcNhVL4hMv0QKekpk9z8L/l6JqBqbCoe4VoZkLlViQaAy3DUXj7ZYYO4+ Adu7q3t7YtTW1UhdT0wZjHHjO4UkIu7Ei0CtvvEaRwrChbHlfqqVPuGW577T8ja/SD3d ClULQm8hLFiF6PHP//ncZ+mAUnALcY7R27vU6w653Gbd1KPu3VCATLN5pCE2rxMs5LAR In1Q== X-Gm-Message-State: AOAM532psdtI5CaPkVsWYBrfQ5+dYb2v2Id3ezzsh4b1Tgxj9Q3TFaaf njEovyGdsuZ8rb2yCT0/dCY67Q== X-Google-Smtp-Source: ABdhPJx1rtSdVuiiyy5iVOmwPt+Um0lx4nMkwJpGQD/JuUD1FLEgHSpCgTfxVv0hcA4cMAUz7kzYFA== X-Received: by 2002:adf:fb44:: with SMTP id c4mr1892372wrs.179.1630567332137; Thu, 02 Sep 2021 00:22:12 -0700 (PDT) Received: from ?IPv6:2a01:e0a:410:bb00:ad0b:57f0:790e:61f9? ([2a01:e0a:410:bb00:ad0b:57f0:790e:61f9]) by smtp.gmail.com with ESMTPSA id y11sm1166719wru.0.2021.09.02.00.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 00:22:11 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH] include/uapi/linux/xfrm.h: Fix XFRM_MSG_MAPPING ABI breakage To: Eugene Syromiatnikov , Steffen Klassert , Herbert Xu , "David S. Miller" , Antony Antony , Christian Langrock Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dmitry V. Levin" , linux-api@vger.kernel.org References: <20210901153407.GA20446@asgard.redhat.com> From: Nicolas Dichtel Organization: 6WIND Message-ID: Date: Thu, 2 Sep 2021 09:22:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901153407.GA20446@asgard.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 01/09/2021 à 17:34, Eugene Syromiatnikov a écrit : > Commit 2d151d39073a ("xfrm: Add possibility to set the default to block > if we have no policy") broke ABI by changing the value of the XFRM_MSG_MAPPING > enum item. Fix it by placing XFRM_MSG_SETDEFAULT/XFRM_MSG_GETDEFAULT > to the end of the enum, right before __XFRM_MSG_MAX. > > Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy") > Signed-off-by: Eugene Syromiatnikov Acked-by: Nicolas Dichtel