From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3
Date: Fri, 10 Jun 2022 12:14:04 +0200 [thread overview]
Message-ID: <ef62a7bb-2217-2947-17dd-fc4a51acdea5@linaro.org> (raw)
In-Reply-To: <4a7f8ab6-c061-3861-5790-b6c0fbd7cad1@gmail.com>
On 09/06/2022 22:31, Jacek Anaszewski wrote:
> Hi Krzysztof,
>
> On 6/7/22 10:53, Krzysztof Kozlowski wrote:
>> Add common LED properties - the function and color - to aat1290 flash
>> LED node in Galaxy S3.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> index 72901772fcad..d76f3678dcab 100644
>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> @@ -7,6 +7,7 @@
>> */
>>
>> /dts-v1/;
>> +#include <dt-bindings/leds/common.h>
>> #include "exynos4412-midas.dtsi"
>>
>> / {
>> @@ -27,6 +28,8 @@ led-controller {
>>
>> led {
>> label = "flash";
>> + function = LED_FUNCTION_FLASH;
>> + color = <LED_COLOR_ID_WHITE>;
>
> Addition of these two properties will not change anything because
> the label has precedence. It is deprecated, but if you introduce
> function and color to the binding instead of the label, the resulting
> LED class device name will change.
Which is not necessarily what we want, right? Adding these properties is
a proper description of hardware, regardless whether current Linux
implementation uses them or not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-10 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 8:53 [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema Krzysztof Kozlowski
2022-06-07 8:53 ` [PATCH 2/3] ARM: dts: exynos: align aat1290 flash LED node with bindings in Galaxy S3 Krzysztof Kozlowski
2022-06-07 8:53 ` [PATCH 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node " Krzysztof Kozlowski
2022-06-09 20:31 ` Jacek Anaszewski
2022-06-10 10:14 ` Krzysztof Kozlowski [this message]
2022-06-12 15:09 ` Jacek Anaszewski
2022-06-12 17:06 ` Krzysztof Kozlowski
2022-06-18 21:14 ` Henrik Grimler
2022-06-20 23:47 ` [Replicant] " Denis 'GNUtoo' Carikli
2022-06-09 20:10 ` [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema Rob Herring
2022-06-09 20:28 ` Jacek Anaszewski
2022-06-10 10:12 ` Krzysztof Kozlowski
2022-06-12 15:08 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef62a7bb-2217-2947-17dd-fc4a51acdea5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).