From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbcHHSoR (ORCPT ); Mon, 8 Aug 2016 14:44:17 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:33562 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbcHHSoP (ORCPT ); Mon, 8 Aug 2016 14:44:15 -0400 Subject: Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags To: Chen Feng , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1469844551-68688-1-git-send-email-puck.chen@hisilicon.com> Cc: suzhuangluan@hisilicon.com, dan.zhao@hisilicon.com, oliver.fu@hisilicon.com, qijiwen@hisilicon.com, saberlily.xia@hisilicon.com, xuyiping@hisilicon.com, puck.chen@foxmail.com From: Laura Abbott Message-ID: Date: Mon, 8 Aug 2016 11:44:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1469844551-68688-1-git-send-email-puck.chen@hisilicon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29/2016 07:09 PM, Chen Feng wrote: > It's useful to show the current memory in detail when alloc failed. > > And, there may be a lot of high order alloc failed, just show memory > when an order 0 alloc failed. > > Signed-off-by: Chen Feng > --- > drivers/staging/android/ion/ion_system_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c > index b69dfc7..c3b7975 100644 > --- a/drivers/staging/android/ion/ion_system_heap.c > +++ b/drivers/staging/android/ion/ion_system_heap.c > @@ -28,7 +28,7 @@ > > static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN | > __GFP_NORETRY) & ~__GFP_RECLAIM; > -static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN); > +static gfp_t low_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO); > static const unsigned int orders[] = {8, 4, 0}; > static const int num_orders = ARRAY_SIZE(orders); > static int order_to_index(unsigned int order) > Acked-by: Laura Abbott