From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286A2C63697 for ; Thu, 26 Nov 2020 14:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEBF62075A for ; Thu, 26 Nov 2020 14:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390038AbgKZOCq (ORCPT ); Thu, 26 Nov 2020 09:02:46 -0500 Received: from foss.arm.com ([217.140.110.172]:33816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389434AbgKZOCp (ORCPT ); Thu, 26 Nov 2020 09:02:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C030A31B; Thu, 26 Nov 2020 06:02:44 -0800 (PST) Received: from [10.57.29.239] (unknown [10.57.29.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82CB33F71F; Thu, 26 Nov 2020 06:02:43 -0800 (PST) Subject: Re: [PATCH v4 0/3] Improve the estimations in Intelligent Power Allocation To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, amitk@kernel.org, Dietmar.Eggemann@arm.com, ionela.voinescu@arm.com References: <20201124161025.27694-1-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: Date: Thu, 26 Nov 2020 14:02:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/26/20 1:09 PM, Daniel Lezcano wrote: > On 26/11/2020 13:49, Lukasz Luba wrote: >> Hi Daniel, >> >> On 11/24/20 4:10 PM, Lukasz Luba wrote: >>> Hi all, >>> >>> The Intelligent Power Allocation (IPA) estimates the needed >>> coefficients for >>> internal algorithm. It can also estimate the sustainable power value >>> when the >>> DT has not provided one. Fix the 'k_i' coefficient which might be to big >>> related to the other values, when the sustainable power is in an abstract >>> scale. Do the estimation of sustainable power only once and avoid >>> expensive >>> calculation every time the IPA is called. Do the estimation of PID >>> constants >>> when there was user update via sysfs to sustainable power. >>> >>> The patch set should apply on top next-20201124 >>> >>> Changes: >>> v4: >>> - added new function get_sustainable_power() which handles use cases >>>    when the value should be estimated again or simply returned >>> - added sustainable_power in the power_allocator_params to track if there >>>    was a change to sustainable_power by the user via sysfs >>> - addressed Daniel's comments that sustainable power set via sysfs should >>>    trigger PID coefficients estimation >>> - removed 'force' argument from estimate_pid_constants() and make it >>> ready >>>    for updates due to new value for sust. power from sysfs >>> - abandoned the design from v3 with a single function responsible for >>>    estimation both sust. power and PID const. requested by Ionela >>> v3 [1]: >>> - changed estimate_pid_constants to estimate_tzp_constants and related >>> comments >>> - estimate the PID coefficients always together with sust. power >>> - added print indicating that we are estimating sust. power and PID >>> const. >>> - don't use local variable 'sustainable_power' >>> >>> Regards, >>> Lukasz Luba >>> >>> [1] >>> https://lore.kernel.org/lkml/20201009135850.14727-1-lukasz.luba@arm.com/ >>> >>> Lukasz Luba (3): >>>    thermal: power allocator: change the 'k_i' coefficient estimation >>>    thermal: power allocator: refactor sustainable power estimation >>>    thermal: power allocator: change the 'k_*' always in >>>      estimate_pid_constants() >>> >>>   drivers/thermal/gov_power_allocator.c | 76 +++++++++++++++++---------- >>>   1 file changed, 49 insertions(+), 27 deletions(-) >>> >> >> Gentle ping. This is a self contained change to only power allocator >> file. It addresses also your requirement regarding sustainable_power >> changed via sysfs. >> >> Could you take it please? It should apply smoothly in your tree. > > Actually, I'm waiting for Ionela and Dietmar ack. > > Are they maintainers of this file that you need their ACKs? Maybe I should drop mine then.