From: "Matias Bjørling" <mb@lightnvm.io>
To: javier@cnexlabs.com
Cc: igor.j.konopko@intel.com, marcin.dziegielewski@intel.com,
hans.holmberg@cnexlabs.com, hlitz@ucsc.edu,
youngtack.jin@circuitblvd.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: pblk: remove unnecessary drive version check
Date: Fri, 3 Aug 2018 14:55:30 +0200 [thread overview]
Message-ID: <ef8cd1ac-623b-96ed-1a7f-3e390fcc51d5@lightnvm.io> (raw)
In-Reply-To: <130c689a-723f-a32a-96e3-a7a59ff6b7b8@lightnvm.io>
On 08/03/2018 02:39 PM, Matias Bjørling wrote:
> On 08/03/2018 02:18 PM, Javier Gonzalez wrote:
>>> On 2 Aug 2018, at 22.58, Matias Bjørling <mb@lightnvm.io> wrote:
>>>
>>> The nvme driver checks for 1.2 and 2.0 compatibility. If an unsupported
>>> version is reported, the device will not be initialized.
>>>
>>> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
>>> ---
>>> drivers/lightnvm/pblk-init.c | 8 --------
>>> 1 file changed, 8 deletions(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>>> index 537e98f2b24a..e9e2fedff387 100644
>>> --- a/drivers/lightnvm/pblk-init.c
>>> +++ b/drivers/lightnvm/pblk-init.c
>>> @@ -1202,14 +1202,6 @@ static void *pblk_init(struct nvm_tgt_dev
>>> *dev, struct gendisk *tdisk,
>>> pblk->state = PBLK_STATE_RUNNING;
>>> pblk->gc.gc_enabled = 0;
>>>
>>> - if (!(geo->version == NVM_OCSSD_SPEC_12 ||
>>> - geo->version == NVM_OCSSD_SPEC_20)) {
>>> - pblk_err(pblk, "OCSSD version not supported (%u)\n",
>>> - geo->version);
>>> - kfree(pblk);
>>> - return ERR_PTR(-EINVAL);
>>> - }
>>> -
>>> if (geo->version == NVM_OCSSD_SPEC_12 && geo->dom & NVM_RSP_L2P) {
>>> pblk_err(pblk, "host-side L2P table not supported. (%x)\n",
>>> geo->dom);
>>> --
>>> 2.11.0
>>
>> The same comment goes for this patch. pblk does support 2.0 and 1.2
>> today, but it is not guaranteed it will support a new revision straight
>> away. So I think that a check wither here or through the .capabilities I
>> proposed on the other patch is necessary.
>>
>
> Works for me. I'll send another patch that enables pblk target to tell
> which version it supports.
On second thought. The idea is that pblk will not have to think about
1.2/2.0. The core will expose a general address format, etc., such that
pblk doesn't have to be complicated by that.
I am working on the various pieces and moving them to core. The patch
may have gone out a bit early. I will send this again when the 1.2/2.0
conversions have been applied.
next prev parent reply other threads:[~2018-08-03 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 20:58 [PATCH] lightnvm: pblk: remove unnecessary drive version check Matias Bjørling
2018-08-03 12:18 ` Javier Gonzalez
2018-08-03 12:39 ` Matias Bjørling
2018-08-03 12:55 ` Matias Bjørling [this message]
2018-08-03 13:05 ` Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef8cd1ac-623b-96ed-1a7f-3e390fcc51d5@lightnvm.io \
--to=mb@lightnvm.io \
--cc=hans.holmberg@cnexlabs.com \
--cc=hlitz@ucsc.edu \
--cc=igor.j.konopko@intel.com \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.dziegielewski@intel.com \
--cc=youngtack.jin@circuitblvd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).