From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C6AC77B7E for ; Thu, 25 May 2023 10:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240821AbjEYKMB (ORCPT ); Thu, 25 May 2023 06:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240716AbjEYKLw (ORCPT ); Thu, 25 May 2023 06:11:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610B6197 for ; Thu, 25 May 2023 03:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685009469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jp/SVeiGCmaKs6UW+b11J6WubNV/huB/Y1oH54gpyiY=; b=DcC2WfRVMo83Alm4de1caSv6FHLpjieqJxhNHvQKnkZz25jm2C2wQDdb5YlDmFuSOPGbFq TGgPgUBmzSJelJG0jr7SlERJF5y2b4pe9wvFfOqWe9/iwVnqXNbGCrfpNgHejl8DdMPd6L eNQy6RcH8GLX9tXSNKrI++mYJBNrlKw= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-EsEi-2UGNb-O__JFD8KRkg-1; Thu, 25 May 2023 06:11:08 -0400 X-MC-Unique: EsEi-2UGNb-O__JFD8KRkg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-96fd6bd135dso53461866b.1 for ; Thu, 25 May 2023 03:11:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685009467; x=1687601467; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jp/SVeiGCmaKs6UW+b11J6WubNV/huB/Y1oH54gpyiY=; b=SLcLbovHBoZrd3pho+IWBw95gzhVax7oYK32B7e494QHHhIiRNfCjkdJDDans9K5V2 gU6AqKymQtetsIZRDiHU1Z1skDiM+4kjVVehR0xxWlPPrF5yImnEm6rRhGLSC0IMxSyB rLgXe31jqDg4asXeh9PHkKq3alpHa2WCDz6GgdvVYjNcbRt2jGy3wIQHflqtIKJWrMaN /qZOJR+WuKuvaHlqFDI8D/s6Iju5UVbh2pmwLTjiOqcvV+teT6RNNZn6PZxsI45DNMBA eNvHQnpLo40NrGUiQs0iEfc+M3Klm5vcgaa8a15LAiDTsKashK1/HCHXpORKh1xy/LjF XGNw== X-Gm-Message-State: AC+VfDyom09rX8+xxUZPsCm90Ox6/oZVaAMrTMzIjNNdFEqkxtZu7Cpb sEiK3W2UDU2qBMY8af77azVScUjbH8d/fprQXQPyF3F5mPqMKzTxinduOiMGik2FqkOk5shbGuc cnObIbO6k2DT/nSy4N2gukUaO X-Received: by 2002:a17:907:6d97:b0:973:bb6f:83ef with SMTP id sb23-20020a1709076d9700b00973bb6f83efmr940104ejc.77.1685009467307; Thu, 25 May 2023 03:11:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ658RP8jZmcIMUzcThnJ/vJ+cV2iR7KINpxkNGBprL89ouE7x4cDA88Ks6OjOD5LZw3hH4SqQ== X-Received: by 2002:a17:907:6d97:b0:973:bb6f:83ef with SMTP id sb23-20020a1709076d9700b00973bb6f83efmr940076ejc.77.1685009466994; Thu, 25 May 2023 03:11:06 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id z26-20020a170906715a00b00959b3c30f2csm627263ejj.222.2023.05.25.03.11.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 03:11:06 -0700 (PDT) Message-ID: Date: Thu, 25 May 2023 12:11:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 0/4] leds: simatic-ipc-leds-gpio: split up Content-Language: en-US, nl To: Henning Schild , Pavel Machek , Lee Jones , Mark Gross , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20230524124628.32295-1-henning.schild@siemens.com> From: Hans de Goede In-Reply-To: <20230524124628.32295-1-henning.schild@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/24/23 14:46, Henning Schild wrote: > changes since v3: > - add terminator entries to all gpio lookup tables as new p1 Thank you. The entire series looks good to me: Acked-by: Hans de Goede for the entire series. Regards, Hans > > changes since v2: > - some more style changes from review > > changes since v1: > - move from header- to -core.c-based implementation > - style changes from review > > This series mainly splits the one GPIO driver into two. The split allows > to clearly model runtime and compile time dependencies on the GPIO chip > drivers. > > p2 is kind of not too related to that split but also prepares for more > GPIO based drivers to come. > > p3 takes the driver we had and puts some of its content into a -core, > to be used by the two drivers. > > p4 deals with more fine-grained configuration posibilities and compile > time dependencies. > > Henning Schild (4): > leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables > leds: simatic-ipc-leds-gpio: move two extra gpio pins into another > table > leds: simatic-ipc-leds-gpio: split up into multiple drivers > leds: simatic-ipc-leds-gpio: introduce more Kconfig switches > > drivers/leds/simple/Kconfig | 31 +++- > drivers/leds/simple/Makefile | 5 +- > .../simple/simatic-ipc-leds-gpio-apollolake.c | 66 +++++++++ > .../leds/simple/simatic-ipc-leds-gpio-core.c | 104 +++++++++++++ > .../simple/simatic-ipc-leds-gpio-f7188x.c | 66 +++++++++ > drivers/leds/simple/simatic-ipc-leds-gpio.c | 139 ------------------ > drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++ > drivers/leds/simple/simatic-ipc-leds.c | 1 - > drivers/platform/x86/simatic-ipc.c | 7 +- > 9 files changed, 293 insertions(+), 148 deletions(-) > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c > delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h >