From: John Hubbard <jhubbard@nvidia.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man <linux-man@vger.kernel.org>,
<linux-api@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
Jann Horn <jannh@google.com>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2] mmap.2: MAP_FIXED updated documentation
Date: Mon, 4 Dec 2017 18:14:18 -0800 [thread overview]
Message-ID: <efb6eae4-7f30-42c3-0efe-0ab5fbf0fdb4@nvidia.com> (raw)
In-Reply-To: <20171204105549.GA31332@rei>
On 12/04/2017 02:55 AM, Cyril Hrubis wrote:
> Hi!
> I know that we are not touching the rest of the existing description for
> MAP_FIXED however the second sentence in the manual page says that "addr
> must be a multiple of the page size." Which however is misleading as
> this is not enough on some architectures. Code in the wild seems to
> (mis)use SHMLBA for aligment purposes but I'm not sure that we should
> advise something like that in the manpages.
>
> So what about something as:
>
> "addr must be suitably aligned, for most architectures multiple of page
> size is sufficient, however some may impose additional restrictions for
> page mapping addresses."
>
Hi Cyril,
Right, so I've been looking into this today, and I think we can go a bit
further than that, even. The kernel, as far back as the *original* git
commit in 2005, implements mmap on ARM by requiring that the address is
aligned to SHMLBA:
arch/arm/mm/mmap.c:50:
if (flags & MAP_FIXED) {
if (aliasing && flags & MAP_SHARED &&
(addr - (pgoff << PAGE_SHIFT)) & (SHMLBA - 1))
return -EINVAL;
return addr;
}
So, given that this has been the implementation for the last 12+ years (and
probably the whole time, in fact), I think we can be bold enough to use this
wording for the second sentence of MAP_FIXED:
"addr must be a multiple of SHMLBA (<sys/shm.h>), which in turn is either
the system page size (on many architectures) or a multiple of the system
page size (on some architectures)."
What do you think?
thanks,
John Hubbard
NVIDIA
> Which should at least hint the reader that this is architecture specific.
>
next prev parent reply other threads:[~2017-12-05 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 2:14 [PATCH v2] mmap.2: MAP_FIXED updated documentation john.hubbard
2017-12-04 10:55 ` Cyril Hrubis
2017-12-05 2:14 ` John Hubbard [this message]
2017-12-05 7:05 ` Michal Hocko
2017-12-05 7:42 ` John Hubbard
2017-12-05 8:52 ` Michal Hocko
2017-12-06 10:01 ` Cyril Hrubis
2017-12-06 21:21 ` John Hubbard
2017-12-07 12:58 ` Cyril Hrubis
2017-12-07 14:02 ` Michal Hocko
2017-12-09 17:19 ` Pavel Machek
2017-12-10 7:44 ` John Hubbard
2017-12-04 11:31 ` Mike Rapoport
2017-12-05 2:52 ` John Hubbard
2017-12-05 7:08 ` Michal Hocko
2017-12-05 7:43 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efb6eae4-7f30-42c3-0efe-0ab5fbf0fdb4@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=chrubis@suse.cz \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mtk.manpages@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).