From: Lars-Peter Clausen <lars@metafoo.de>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Michael Auchter <michael.auchter@ni.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible strings
Date: Tue, 2 Feb 2021 21:55:56 +0100 [thread overview]
Message-ID: <efbfbb94-bf61-5503-9833-df23709f56a2@metafoo.de> (raw)
In-Reply-To: <20210202181427.3934218-1-robh@kernel.org>
On 2/2/21 7:14 PM, Rob Herring wrote:
> The example uses 'adi,ad5686', but the schema fails to document it. Given
> the filename and there is a similar part AD5686, let's just add the
> compatible strings including the 'r' variant.
There are two variants of this chip. One with a SPI interface and one
with a I2C interface. This binding document only describes the I2C
variants. But the ad5686 is a SPI variant.
I think this is a typo and we should replace ad5686 with ad5696,
including the document name.
>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Michael Auchter <michael.auchter@ni.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index 8065228e5df8..190919291828 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -19,6 +19,8 @@ properties:
> - adi,ad5338r
> - adi,ad5671r
> - adi,ad5675r
> + - adi,ad5686
> + - adi,ad5686r
> - adi,ad5691r
> - adi,ad5692r
> - adi,ad5693
next prev parent reply other threads:[~2021-02-02 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:14 [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible strings Rob Herring
2021-02-02 20:55 ` Lars-Peter Clausen [this message]
2021-02-02 21:10 ` Rob Herring
2021-02-06 15:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbfbb94-bf61-5503-9833-df23709f56a2@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).