From: Derek Robson <robsonde@gmail.com>
To: david.kershner@unisys.com, gregkh@linuxfoundation.org,
Timothy.Sell@unisys.com
Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Derek Robson <robsonde@gmail.com>
Subject: [PATCH 1/2] Staging: unisys: visorbus: style fix, using octal file permissions
Date: Sat, 7 Jan 2017 16:48:27 +1300 [thread overview]
Message-ID: <efc63971b9cfda1cfc6e3121153a43183506bd74.1483760409.git.robsonde@gmail.com> (raw)
In-Reply-To: <cover.1483760409.git.robsonde@gmail.com>
Changed file permissions to octal style.
Found with checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3457ef338e1e..28ca291a4053 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
goto err_hdr_info;
}
dev->debugfs_client_bus_info =
- debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("client_bus_info", 0440,
dev->debugfs_dir, dev,
&client_bus_info_debugfs_fops);
if (!dev->debugfs_client_bus_info) {
@@ -1337,10 +1337,10 @@ visorbus_exit(void)
debugfs_remove_recursive(visorbus_debugfs_dir);
}
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
MODULE_PARM_DESC(visorbus_forcematch,
"1 to force a successful dev <--> drv match");
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
MODULE_PARM_DESC(visorbus_forcenomatch,
"1 to force an UNsuccessful dev <--> drv match");
--
2.11.0
next prev parent reply other threads:[~2017-01-07 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 3:48 [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions Derek Robson
2017-01-07 3:48 ` Derek Robson [this message]
2017-01-07 3:48 ` [PATCH 2/2] " Derek Robson
2017-01-07 4:54 ` [PATCH 0/2] " Kershner, David A
2017-01-07 7:44 ` Greg KH
2017-01-09 20:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efc63971b9cfda1cfc6e3121153a43183506bd74.1483760409.git.robsonde@gmail.com \
--to=robsonde@gmail.com \
--cc=Timothy.Sell@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).