From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5B9C433FF for ; Thu, 1 Aug 2019 01:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D33912067D for ; Thu, 1 Aug 2019 01:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729262AbfHABbc (ORCPT ); Wed, 31 Jul 2019 21:31:32 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3285 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725942AbfHABbc (ORCPT ); Wed, 31 Jul 2019 21:31:32 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E2944ED38F34723C517A; Thu, 1 Aug 2019 09:31:30 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 09:31:23 +0800 Subject: Re: [PATCH 07/22] staging: erofs: remove redundant #include "internal.h" To: Gao Xiang CC: Greg Kroah-Hartman , , , LKML , , Miao Xie References: <20190729065159.62378-1-gaoxiang25@huawei.com> <20190729065159.62378-8-gaoxiang25@huawei.com> <52072867-a9ae-5730-0ce4-47dd8dcb2d8c@huawei.com> <14ac0fe7-1742-875b-b01a-78b49cae303a@huawei.com> From: Chao Yu Message-ID: Date: Thu, 1 Aug 2019 09:31:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <14ac0fe7-1742-875b-b01a-78b49cae303a@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/31 20:54, Gao Xiang wrote: > > > On 2019/7/31 20:07, Chao Yu wrote: >> Hi Xiang, >> >> On 2019/7/31 15:08, Gao Xiang wrote: >>> Hi Chao, >>> >>> On 2019/7/31 15:03, Chao Yu wrote: >>>> On 2019/7/29 14:51, Gao Xiang wrote: >>>>> Because #include "internal.h" is included in xattr.h >>>> >>>> I think it would be better to remove "internal.h" in xattr.h, and include them >>>> both in .c file in where we need xattr definition. >>> >>> It seems that all xattr related source files needing internal.h, >>> and we need "EROFS_V(inode)", "struct erofs_sb_info", ... stuffs in xattr.h, >>> which is defined in internal.h... >> >> Since I checked f2fs', it looks it's okay to don't include internal.h for >> xattr.h, if .c needs xattr.h, we can just include interanl.h and xattr.h in the >> head of it, it's safe. > > I think xattr.h should be used independently (all dependencies of xattr.h should > be included in xattr.h, most of include files behave like that)... Maybe it is > not a good way to follow f2fs... Yes, I've confirmed it's fine to do this, let's go ahead. :) Thanks, > > Thanks, > Gao Xiang > >> >> Thanks, >> >>> >>> Thanks, >>> Gao Xiang >>> >>>> >>>> Thanks, >>>> >>> . >>> > . >