From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: drop misleading usb_set_intfdata() kernel doc
Date: Mon, 12 Dec 2022 11:19:00 +0100 [thread overview]
Message-ID: <efca6b26-fb20-ae38-0fc4-8612f1ee150b@suse.com> (raw)
In-Reply-To: <20221211120626.12210-1-johan@kernel.org>
On 11.12.22 13:06, Johan Hovold wrote:
> Due to a misunderstanding, a redundant and misleading kernel doc comment
> for usb_set_intfdata() was recently added which claimed that the driver
> data pointer must not be cleared during disconnect before "all actions
> [are] completed", which is both imprecise and incorrect.
OK, but is that a reason to remove all kerneldoc? Kerneldoc is generally
a good thing. And if a pointer is NULLed by driver core, that will need
to be in it. IMHO you'd better just remove the questionable part of the
kerneldoc.
Regards
Oliver
next prev parent reply other threads:[~2022-12-12 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 12:06 [PATCH] USB: drop misleading usb_set_intfdata() kernel doc Johan Hovold
2022-12-12 10:19 ` Oliver Neukum [this message]
2022-12-12 10:31 ` Johan Hovold
2022-12-12 11:13 ` Oliver Neukum
2022-12-12 13:14 ` Johan Hovold
2022-12-12 13:27 ` Oliver Neukum
2022-12-12 13:40 ` Johan Hovold
2022-12-12 14:04 ` Oliver Neukum
2022-12-12 14:14 ` Johan Hovold
2022-12-12 15:25 ` Alan Stern
2022-12-12 16:08 ` Johan Hovold
2022-12-12 16:39 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efca6b26-fb20-ae38-0fc4-8612f1ee150b@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).