From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7DDECDFBB for ; Fri, 20 Jul 2018 05:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8178920673 for ; Fri, 20 Jul 2018 05:06:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ykZqXGtH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8178920673 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbeGTFwc (ORCPT ); Fri, 20 Jul 2018 01:52:32 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:54870 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbeGTFwc (ORCPT ); Fri, 20 Jul 2018 01:52:32 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w6K54Skj118109; Fri, 20 Jul 2018 00:04:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1532063069; bh=M73kmYmuky3q5wzgbSl557Y/Z5XjZabWSqEoNrth75Q=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ykZqXGtHsXrUJq0l9lhURDAI9xGxFIx4yYHqZIxcY3SgpRrt3TiLQUHGFiyZQ7Q6m uEkSjlznNc5M2IFTUt5TtrfDqG68JmOAwo39/n44lZHRh4n3c6pgkomLafoDleA9T/ YFPdwze5+YHFDDEGXYW+/OQicjxiuNPy+6TtQofU= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w6K54SP9002002; Fri, 20 Jul 2018 00:04:28 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 20 Jul 2018 00:04:28 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 20 Jul 2018 00:04:28 -0500 Received: from [172.24.190.172] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w6K54IHY006187; Fri, 20 Jul 2018 00:04:19 -0500 Subject: Re: [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD To: Srinivas Kandagatla , Bartosz Golaszewski , Andrew Lunn CC: Ladislav Michl , Florian Fainelli , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Lukas Wunner , Rob Herring , Dan Carpenter , Ivan Khoronzhuk , David Lechner , Greg Kroah-Hartman , Jonathan Corbet , Linux ARM , Linux Kernel Mailing List , , , Bartosz Golaszewski References: <20180629094039.7543-1-brgl@bgdev.pl> <20180629094039.7543-9-brgl@bgdev.pl> <03b77e24-9ab9-fa01-2387-9de0408a9942@gmail.com> <20180704070919.GA14051@lenoch> From: Sekhar Nori Message-ID: Date: Fri, 20 Jul 2018 10:34:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 July 2018 02:26 PM, Srinivas Kandagatla wrote: > > > On 16/07/18 09:50, Sekhar Nori wrote: >> On Friday 13 July 2018 11:30 PM, Bartosz Golaszewski wrote: >> >>> We're getting close to rc5 so I'd like to make a case for this series >>> again. >>> >>> I understand that there's more to do than just the changes introduced >>> here, but we shouldn't try to fix several problems in many different >>> places at once. There's just too many moving pieces. I'd rather start >>> merging small improvements right away. >>> >>> The idea behind this series is to remove (almost) all users of >>> at24_platform_data. The davinci_emac patches are there only because we >>> need to remove some MAC adress reading stuff from the board files. >>> Having this code there and calling it back from EEPROM/MTD drivers is >>> already wrong and we should work towards using nvmem for that anyway. >>> >>> Currently for MTD the nvmem support series seems to be dead and it's >>> going to take some time before anything gets upstream. >>> >>> So I'd like to again ask you to consider picking up the patches from >>> this series to your respective trees or at the very least: I'd like to >>> ask Srinivas to pick up the nvmem patches and Sekhar to take the >>> first, non-controversial batch of davinci platform changes so that >>> we'll have less code to carry for the next release. >> >> I think those are patches 3-7. I can take those if I get an immutable >> commit over v4.18-rc1 from Srinivas with patches 1 & 2 applied. > nvmem patches go via Greg KH char-misc tree, if it makes things easy I > can provide Ack on nvmem patches, so that you can take these patches via > your tree? There is a lot of follow-up traffic on how exactly to develop the needed interfaces for reading mac address in mtd and/or network subsystem. But, I don't think any of that negates the need for nvmem lookups that work for non-device-tree and populating the lookups in mach-davinci board code. I am going to send patches 1-7 to ARM-SoC soon, so please do say if there is any disagreement on this. Thanks, Sekhar > > Let me know. > > --srini >> >> Thanks, >> Sekhar >>