From: "David E. Box" <david.e.box@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Gayatri Kammela <gayatri.kammela@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel_pmc_core: add ACPI dependency
Date: Wed, 21 Apr 2021 10:32:53 -0700 [thread overview]
Message-ID: <eff01b04545eb14f5547b45b1c620e244ce25631.camel@linux.intel.com> (raw)
In-Reply-To: <20210421134957.3329062-1-arnd@kernel.org>
Thanks for the fix Arnd. Thought I could get away with not adding the
dependency since the function is stubbed but didn't realize struct
acpi_device wouldn't be defined. Should have build tested it.
David
On Wed, 2021-04-21 at 15:49 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver now fails to build without ACPI:
>
> drivers/platform/x86/intel_pmc_core.c: In function
> 'pmc_core_get_tgl_lpm_reqs':
> drivers/platform/x86/intel_pmc_core.c:617:41: error: invalid use of
> undefined type 'struct acpi_device'
> 617 | out_obj = acpi_evaluate_dsm(adev->handle,
> &s0ix_dsm_guid, 0,
>
> This could probably be made optional, but it won't be used without
> ACPI in practice, so just add a Kconfig dependency.
>
> Fixes: 428131364f00 ("platform/x86: intel_pmc_core: Get LPM
> requirements for Tiger Lake")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index 697fc446ac41..2714f7c3843e 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1194,6 +1194,7 @@ config INTEL_MRFLD_PWRBTN
> config INTEL_PMC_CORE
> tristate "Intel PMC Core driver"
> depends on PCI
> + depends on ACPI
> help
> The Intel Platform Controller Hub for Intel Core SoCs
> provides access
> to Power Management Controller registers via various
> interfaces. This
prev parent reply other threads:[~2021-04-21 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:49 [PATCH] platform/x86: intel_pmc_core: add ACPI dependency Arnd Bergmann
2021-04-21 14:14 ` Hans de Goede
2021-04-21 17:32 ` David E. Box [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff01b04545eb14f5547b45b1c620e244ce25631.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gayatri.kammela@intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).