From: Jens Axboe <axboe@kernel.dk>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Jeff Moyer <jmoyer@redhat.com>
Cc: jack@suse.cz, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
anton@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits
Date: Tue, 10 Jan 2017 13:31:11 -0700 [thread overview]
Message-ID: <eff698ef-2677-bb7c-1caf-2b99d95050e7@kernel.dk> (raw)
In-Reply-To: <4971281.Bg9JD0zqnv@localhost.localdomain>
On 01/09/2017 10:27 PM, Chandan Rajendra wrote:
> On Monday, January 09, 2017 04:42:58 PM Jeff Moyer wrote:
>> Commit 20ce44d545844 ("do_direct_IO: Use inode->i_blkbits to compute
>> block count to be cleaned") introduced a regression: if the block size
>> of the block device is changed while a direct I/O request is being
>> setup, it can result in a panic. See commit ab73857e354ab ("direct-io:
>> don't read inode->i_blkbits multiple times") for the reasoning, and
>> commit b87570f5d3496 ("Fix a crash when block device is read and block
>> size is changed at the same time") for a more detailed problem
>> description and reproducer.
>>
>> Fixes: 20ce44d545844
>> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>>
>> ---
>> Chandan, can you please test this to ensure this still fixes your problem?
>
> This patch fixes the failure,
>
> Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
I've updated the patch, thanks guys.
--
Jens Axboe
prev parent reply other threads:[~2017-01-10 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 14:47 [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned Chandan Rajendra
2017-01-09 13:52 ` Christoph Hellwig
2017-01-09 15:32 ` Jens Axboe
2017-01-09 16:04 ` Jeff Moyer
2017-01-09 20:20 ` Jan Kara
2017-01-09 21:42 ` [PATCH] direct-io: don't introduce another read of inode->i_blkbits Jeff Moyer
2017-01-09 21:44 ` Jens Axboe
2017-01-10 5:27 ` Chandan Rajendra
2017-01-10 20:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff698ef-2677-bb7c-1caf-2b99d95050e7@kernel.dk \
--to=axboe@kernel.dk \
--cc=anton@samba.org \
--cc=chandan@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).