From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 830CCC433F5 for ; Wed, 20 Apr 2022 05:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359366AbiDTFYU (ORCPT ); Wed, 20 Apr 2022 01:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235111AbiDTFYO (ORCPT ); Wed, 20 Apr 2022 01:24:14 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3E6F3587B; Tue, 19 Apr 2022 22:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650432089; x=1681968089; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=SfesI4khtBjUJgxDq/Dosd4z9f8CYx2PpAzYtY+D6RE=; b=TIIYG+nDC/rWBPX0b5YerQduJmUL8NTK+cVTgfQrJdgeDtQS7RB+zOxy AkAY4k7Yvq6zKalYVbcbP5XONW01x+/w2qkYFH61X6cXRgeT/gAkorBNZ xVYOirFz500VlkCT97HXDGGRbo8KIqwEUg6F8KPh2tl5lNA1ijSdIZk2c LdzmGBItPRf0DykOmgW3qwqO/pMO4MhqNt+OSEwm46ONpy1aD1JuOOWRr tC64CuC7tsWuPnjT4EwgaUhsCr0ha99N3fRFV2FejWP0e87eatHA8Wb3c DZE4Xrf4FUJPXEZlNih2K3HZ8oYlX0JOW/rJonUOlPeIimL8MJtghd1C0 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="244525655" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="244525655" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 22:21:29 -0700 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="510412173" Received: from sazizi-mobl2.amr.corp.intel.com (HELO [10.212.98.167]) ([10.212.98.167]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 22:21:28 -0700 Message-ID: Date: Tue, 19 Apr 2022 22:21:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Kai Huang , Sathyanarayanan Kuppuswamy , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, isaku.yamahata@intel.com References: <32dcf4c7acc95244a391458d79cd6907125c5c29.1649219184.git.kai.huang@intel.com> From: Dave Hansen Subject: Re: [PATCH v3 04/21] x86/virt/tdx: Add skeleton for detecting and initializing TDX on demand In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/22 21:37, Kai Huang wrote: > On Tue, 2022-04-19 at 07:53 -0700, Sathyanarayanan Kuppuswamy wrote: >> On 4/5/22 9:49 PM, Kai Huang wrote: >>> The TDX module is essentially a CPU-attested software module running >>> in the new Secure Arbitration Mode (SEAM) to protect VMs from malicious >>> host and certain physical attacks. The TDX module implements the >> /s/host/hosts > I don't quite get. Could you explain why there are multiple hosts? This one is an arbitrary language tweak. This: to protect VMs from malicious host and certain physical attacks. could also be written: to protect VMs from malicious host attacks and certain physical attacks. But, it's somewhat more compact to do what was writen. I agree that the language is a bit clumsy and could be cleaned up, but just doing s/host/hosts/ doesn't really improve anything.