linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [RFC][PATCH] regmap: Drop CONFIG_64BIT checks from core
Date: Wed, 26 Jun 2019 13:20:17 +0200	[thread overview]
Message-ID: <f0098753-8219-27c0-d992-a209f3c67d4d@denx.de> (raw)
In-Reply-To: <20190626111508.GA5316@sirena.org.uk>

On 6/26/19 1:15 PM, Mark Brown wrote:
> On Wed, Jun 26, 2019 at 01:31:16AM +0200, Marek Vasut wrote:
>> Drop the CONFIG_64BIT checks from core regmap code, as it is well
>> possible to access e.g. an SPI device with 64bit registers from a
>> 32bit CPU. The CONFIG_64BIT checks are still left in place in the
>> regmap mmio code however.
> 
> The issue with 8 bit

byte

> registers was that we use unsigned long for
> addresses and values and a 64 bit value won't fit in those on a 32 bit
> system.  Some of the bulk APIs will work but things like individual
> register writes and the caches will have problems.

Good thing I sent this as RFC, I realized that shortly after too.

So, what would be the suggestion here ?

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2019-06-26 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 23:31 [RFC][PATCH] regmap: Drop CONFIG_64BIT checks from core Marek Vasut
2019-06-26 11:15 ` Mark Brown
2019-06-26 11:20   ` Marek Vasut [this message]
2019-06-26 12:05     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0098753-8219-27c0-d992-a209f3c67d4d@denx.de \
    --to=marex@denx.de \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).