linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <tglx@linutronix.de>, <mingo@kernel.org>, <hpa@zytor.com>,
	<ebiederm@xmission.com>, <bhe@redhat.com>,
	<izumi.taku@jp.fujitsu.com>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>
Subject: [RFC PATCH v2 04/12] x86/time: Initialize interrupt mode behind timer init
Date: Wed, 19 Apr 2017 17:05:18 +0800	[thread overview]
Message-ID: <f014727476efc586dee5f4bbb95687d7b85d67ad.1492589715.git.douly.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <cover.1492589715.git.douly.fnst@cn.fujitsu.com>

In start_kernel(), firstly, it works on the default interrupy mode, then
switch to the final mode. default mode may not be compatible with the
actual hardware, which cause the delivery interrupt to fail.

Try to set up the final mode as soon as possible. according to the parts
which split from that initialization:

1) Set up the APIC/IOAPIC (including testing whether the timer
   interrupt works)

2) Calibrate TSC

3) Set up the local APIC timer

-- From Thomas Gleixner

Initializing the mode should be earlier than calibrating TSC and needs
testing whether the timer interrupt works at the same time.

Add init_interrupt_mode() to the right location in x86_late_time_init().

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 arch/x86/kernel/time.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index d39c091..04139c8 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -21,6 +21,7 @@
 #include <asm/timer.h>
 #include <asm/hpet.h>
 #include <asm/time.h>
+#include <asm/apic.h>
 
 #ifdef CONFIG_X86_64
 __visible volatile unsigned long jiffies __cacheline_aligned = INITIAL_JIFFIES;
@@ -84,6 +85,13 @@ void __init hpet_time_init(void)
 static __init void x86_late_time_init(void)
 {
 	x86_init.timers.timer_init();
+
+	/*
+	 * After PIT/HPET timers init, select and setup
+	 * the final interrupt mode for delivering IRQs.
+	 */
+	init_interrupt_mode();
+
 	tsc_init();
 }
 
-- 
2.5.5

  parent reply	other threads:[~2017-04-19  9:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19  9:05 [RFC PATCH v2 00/12] Unify interrupt mode and setup it as soon as possible Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 01/12] x86/apic: Replace init_bsp_APIC() with apic_virtual_wire_mode_setup() Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 02/12] x86/apic: Construct a selector for the interrupt delivery mode Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 03/12] x86/apic: Prepare for unifying the interrupt delivery modes setup Dou Liyang
2017-04-19  9:05 ` Dou Liyang [this message]
2017-04-19  9:05 ` [RFC PATCH v2 05/12] x86/ioapic: Refactor the delay logic in timer_irq_works() Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 06/12] x86/apic: Split local APIC timer setup from the APIC setup Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 07/12] x86/apic: Move the logical APIC ID setup from apic_bsp_setup() Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 08/12] x86/apic: Make the interrupt mode setup earlier for SMP-capable system Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 09/12] x86/apic: Setup interrupt mode earlier in case of no SMP motherboard Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 10/12] x86/apic: Make the interrupt mode setup earlier for UP system Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 11/12] x86/apic: Mark the apic_interrupt_mode extern for refining code Dou Liyang
2017-04-19  9:05 ` [RFC PATCH v2 12/12] x86/apic: Remove the apic_virtual_wire_mode_setup() Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f014727476efc586dee5f4bbb95687d7b85d67ad.1492589715.git.douly.fnst@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=bhe@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).