From: Qinglang Miao <miaoqinglang@huawei.com>
To: Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
David Airlie <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit
Date: Mon, 30 Nov 2020 20:26:21 +0800 [thread overview]
Message-ID: <f01d1ce8-8711-f23a-0c7d-7c6870b5ba3a@huawei.com> (raw)
In-Reply-To: <46d1944e-fbbe-075f-1c5b-356b5ce73ee0@arm.com>
在 2020/11/27 18:06, Steven Price 写道:
> On 27/11/2020 09:44, Qinglang Miao wrote:
>> pm_runtime_get_sync will increment pm usage counter even it
>> failed. Forgetting to putting operation will result in a
>> reference leak here.
>>
>> A new function pm_runtime_resume_and_get is introduced in
>> [0] to keep usage counter balanced. So We fix the reference
>> leak by replacing it with new funtion.
>>
>> [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
>> with usage counter")
>>
>> Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
>> ---
>> drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c
>> b/drivers/gpu/drm/panfrost/panfrost_job.c
>> index 30e7b7196..04cf3bb67 100644
>> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
>> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
>> @@ -147,7 +147,7 @@ static void panfrost_job_hw_submit(struct
>> panfrost_job *job, int js)
>> panfrost_devfreq_record_busy(&pfdev->pfdevfreq);
>> - ret = pm_runtime_get_sync(pfdev->dev);
>> + ret = pm_runtime_resume_and_get(pfdev->dev);
>
> Sorry, but in this case this change isn't correct.
> panfrost_job_hw_submit() is expected to be unbalanced (the PM reference
> count is expected to be incremented on return).
>
> In the case where pm_runtime_get_sync() fails, the job will eventually
> timeout, and there's a corresponding pm_runtime_put_noidle() in
> panfrost_reset().
>
> Potentially this could be handled better (e.g. without waiting for the
> timeout to occur), but equally this isn't something we expect to happen
> in normal operation).
>
> Steve
Sorry, I didn't notice the pm_runtime_put_noidle() in
panfrost_job_timedout() before.
Thanks for your reply.
>
>> if (ret < 0)
>> return;
>>
>
> .
prev parent reply other threads:[~2020-11-30 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:44 [PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit Qinglang Miao
2020-11-27 10:06 ` Steven Price
2020-11-30 12:26 ` Qinglang Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01d1ce8-8711-f23a-0c7d-7c6870b5ba3a@huawei.com \
--to=miaoqinglang@huawei.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).