From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Florian Meier <florian.meier@koalo.de>,
<alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: atmel: add SND_SOC_I2C_AND_SPI dependency
Date: Wed, 26 Sep 2018 16:44:23 +0300 [thread overview]
Message-ID: <f0410312-de2b-d0a8-4236-d7a751712767@microchip.com> (raw)
In-Reply-To: <20180926125957.2256982-1-arnd@arndb.de>
On 26.09.2018 15:59, Arnd Bergmann wrote:
> Selecting SND_SOC_WM8731 is only allowed when all its dependencies
> are already there:
>
> WARNING: unmet direct dependencies detected for SND_SOC_WM8731
> Depends on [m]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_I2C_AND_SPI [=m]
> Selected by [y]:
> - SND_SOC_MIKROE_PROTO [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_ATMEL_SOC [=y] && OF [=y]
> Selected by [m]:
> - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_ATMEL_SOC [=y] && (ARCH_AT91 [=y] || COMPILE_TEST [=y]) && ATMEL_SSC [=y] && SND_SOC_I2C_AND_SPI [=m]
> - SND_SOC_ALL_CODECS [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && COMPILE_TEST [=y] && SND_SOC_I2C_AND_SPI [=m]
>
> Fixes: a45f8853a5f9 ("ASoC: Add driver for PROTO Audio CODEC (with a WM8731)")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thank you!
Best regards,
Codrin
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index 81a0712d4f14..64f86f0b87e5 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -101,6 +101,7 @@ config SND_ATMEL_SOC_I2S
> config SND_SOC_MIKROE_PROTO
> tristate "Support for Mikroe-PROTO board"
> depends on OF
> + depends on SND_SOC_I2C_AND_SPI
> select SND_SOC_WM8731
> help
> Say Y or M if you want to add support for MikroElektronika PROTO Audio
>
next prev parent reply other threads:[~2018-09-26 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 12:59 [PATCH] ASoC: atmel: add SND_SOC_I2C_AND_SPI dependency Arnd Bergmann
2018-09-26 13:44 ` Codrin Ciubotariu [this message]
2018-09-27 22:39 ` Applied "ASoC: atmel: add SND_SOC_I2C_AND_SPI dependency" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0410312-de2b-d0a8-4236-d7a751712767@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=florian.meier@koalo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).