From: Robin Murphy <robin.murphy@arm.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
linuxarm@huawei.com, Wei Xu <xuwei5@hisilicon.com>,
linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
mauro.chehab@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dtbs: hikey970: add wifi support
Date: Wed, 26 Aug 2020 13:41:49 +0100 [thread overview]
Message-ID: <f055afe8-1888-48a4-4a4f-0ea031d1942c@arm.com> (raw)
In-Reply-To: <b22e5799fe16a6902f95a8bd3f0f41f5a260c1ad.1598421453.git.mchehab+huawei@kernel.org>
On 2020-08-26 06:57, Mauro Carvalho Chehab wrote:
> The dwmmc2 is used on Hikey 970 for WiFi support. The
> hi3670.dtsi adds it, but with status="disabled".
>
> For WiFi to work,it needs to be enabled. While here, add
> the missing properties:
>
> #address-cells = <0x1>;
> #size-cells = <0x0>;
>
> and add
> ti,non-removable
>
> To DT properties, as the WiFi support is on a non-removable slot.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts
> index f218acceec0b..a2b0d2a1d09d 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts
> @@ -402,6 +402,7 @@ &sd_clk_cfg_func
>
> &dwmmc2 { /* WIFI */
> bus-width = <0x4>;
> + ti,non-removable;
Why? This property is only defined for OMAP HSMMC controllers, which
this isn't, and you've already got the proper generic property right
there below. Plus in terms of Linux it will have zero effect, since it's
only parsed by the omap_hsmmc driver anyway.
> non-removable;
> broken-cd;
> cap-power-off-card;
> @@ -409,8 +410,12 @@ &dwmmc2 { /* WIFI */
> pinctrl-0 = <&sdio_pmx_func
> &sdio_clk_cfg_func
> &sdio_cfg_func>;
> + status = "ok";
Have you noticed the context 6 lines below?
> +
> /* WL_EN */
> vmmc-supply = <&wlan_en>;
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
These are already present in hi3670.dtsi. AFAICS Wifi support was merged
18 months ago :/
Robin.
> status = "ok";
>
> wlcore: wlcore@2 {
>
next prev parent reply other threads:[~2020-08-26 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 5:57 [PATCH] dtbs: hikey970: add wifi support Mauro Carvalho Chehab
2020-08-26 12:41 ` Robin Murphy [this message]
2020-08-26 13:58 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f055afe8-1888-48a4-4a4f-0ea031d1942c@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mani@kernel.org \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).