From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933202AbcKPQon (ORCPT ); Wed, 16 Nov 2016 11:44:43 -0500 Received: from mail-sn1nam01on0045.outbound.protection.outlook.com ([104.47.32.45]:49469 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932759AbcKPQoj (ORCPT ); Wed, 16 Nov 2016 11:44:39 -0500 X-Greylist: delayed 27703 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Nov 2016 11:44:39 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=alex.g@adaptrum.com; Subject: Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed To: Andrew Lunn References: <20161115.221217.2076182289174952941.davem@davemloft.net> <1479286953-11481-1-git-send-email-alex.g@adaptrum.com> <20161116135053.GF19962@lunn.ch> CC: , , , , Gokhan Cosgul From: Alex Message-ID: Date: Wed, 16 Nov 2016 08:44:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116135053.GF19962@lunn.ch> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:647:4080:2997:5f3d:4008:dc17:d4f9] X-ClientProxiedBy: MWHPR19CA0016.namprd19.prod.outlook.com (10.173.246.154) To BN3PR0401MB1169.namprd04.prod.outlook.com (10.160.155.147) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;2:hlEMRneTNf+utK2uToS7/JpTiJ+TwYCqu6Jsbata1Rw5iqxpns54sGZYUhVdCKyu2f0Nu1Va16PEuvmTJ5xpDSwajbYLnhLExOVGkRJF1CdlYbs1G05X2Rg6gHBTqSXFlcjiWskCJz218G+71mXt2ZNDT6fhslNrL+qakqQ8j/4=;3:rIzAdUYcIQOXsBznmRibS4VG2sWd8CCVDTV1tWAAIu1ezK5qaExOFEpvfqC7Su04+6OXFCP/s+bunC45n32bn+FVH0WxxuEllCyXanLQY5eFCt+0J+9kZx8AhOoIpJfsWMnxccwaLHuzkANmvzCCJAjshDYJ0ryus9tdjfSfhTg= X-MS-Office365-Filtering-Correlation-Id: 17519039-df79-440e-e1e5-08d40e3fd99d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN3PR0401MB1169; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;25:wi6TGDV4Bu8ckpkGPu+NahV2kboE3yVu+mcGTeArpbEr6bXai+zZvKmnCSZJUUHK/Z1OoZxqM07oHzWR14HczBqIH5aHv5276lGZ9bul3JBLdTBG8XJCTqa1QhrdOIjHHTEuwGlns1yAOEQ0qd3sO4aCYD3E4ZC4BkIJ3vbq4QPxT+haebBSNCyyKxePadi9/g8KZmhae1KbFvomAT0dtoyoHbT780ra/cpFzpqycsaaCnEcpZo/BvPynbjW3GOSKWPqziRiNFxxFMhXIqAbFvZS/I51Hbvrft8El0uyW9MKdKzhb2sGzvWY+Fw1bipdIDZFTWAjeXyR6FQT5KVsV3z3taze1kirta1p0H8IwtJVLIokjFkqVVsuxruJg87mDNDhtyPCXU9a1wI0mY4JCLXJZqXl3jCyIQUKohP5bqA5GHXRllyYJKuySaBJTcsmO7ekJnJ1vYLpLWyURhkrmO8kAIvi1o4Hs2PY6ncAP8FSyX28YTUbJtcH8KTrRR2+7ZuOlEbWgmXatKbAtEWw2TSAOtQ13jIHdXhsNlk0CuQIwA36JrN9IQYWvEE/jo7gQOZZGCKUkp/gbkP2+fa0+sma9Ap5UGjGcGWVBy4Zgx6kvIjurK4a+fDa5+0xcCnydbIe7MAbA4HVXp/bA9/8wbDRZlXa/EZSEyQ1lgBzjkCeeuzv4bl+vya/dv5U3lPzaREIMbNGSf068A9MxiLyPe0nb/26XLvdBbVXcDGtPvd/CTukM56QIeISg/XFP3GLZ8X7AHf4HkJ36+2veJ6Xfg== X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;31:n/QucOtCARS98KfRqJy+cm+R+5l7kSSz9uYdaUbEYeeqU8GQV9tzxp4rrDAG4iQxX4IBNF88Cbv8/wgCR0+OOCClwU5O34N0LVfY3XWHfGo5Ff3KhHX5w1Lj+SPavZej76OvBhqOG+2Pk6XaSlj75bNwCRtZ/xjT2u8GbLPzo9OCRBtJdVEzC3PenQK4iW5jNpynabtmpQsuAE9TsoVj0eV5FX3HnlVKByrKuO5/qcIxpI9k4G0uD0XmxKgq7U8ZzNCnRPuBaHQiPwTZostN7Q==;4:QevlYj2whE+VTRQ840DjQLGEegUwpba2d1hXCv2zt/Uxdn6ZE9aYn6ZJflsqZyhQRoF5VL2Ut9UPII/RhaWiBB20782jtl/4EIhAzUQcK34h6WsKqNHk5+ON7xwJpt0ah1N2gvJPdAW6T4UsuurdMRCIOdpT9yJdMGgVjzwJiOGma9muENAr9qnUzZ5zVHExMenDsffUs9AbJRjSmJxxcK1c9VL3mJIZ5LQvaWqpc9UZRTmCL2nznbpykU+AfC0lSGprXpYyvY05kdGzJ7moQgVIAM7CBeSep4fVMfuX1lwtmM5xFhuybIePvtC39/4zdIUYQCvyOw9JZ1FaDxJl9O4lu2uQ5tp+YavN7gNNe5pgtsMXUAJc7OoAw5gH3O0x40VixPdrVnYkBdhpfOZtxSgBaJPdm2JXJECr9oqT3R85lNSN2ULSAtnVxKZHbaAMKGIi6VmRv8hPH/aNXvq1Lavy4I+/p7GWhFIxLC2swyc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040281)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041223)(6061324)(6043046);SRVR:BN3PR0401MB1169;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0401MB1169; X-Forefront-PRVS: 01283822F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(377454003)(189002)(199003)(110136003)(81156014)(64126003)(6916009)(2906002)(6116002)(50466002)(86362001)(305945005)(101416001)(68736007)(31696002)(76176999)(65826007)(5660300001)(106356001)(97736004)(36756003)(189998001)(65956001)(50986999)(65806001)(8676002)(229853002)(47776003)(54356999)(4001350100001)(92566002)(31686004)(2950100002)(4326007)(105586002)(23746002)(77096005)(7846002)(81166006)(230700001)(4001430100002)(42186005)(107886002)(33646002)(6666003)(83506001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0401MB1169;H:nuke-mobile.adaptrum;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR0401MB1169;23:B/CLwTkIKI0x2+Yhv1Cys6Y3pQdo6wQs61P?= =?Windows-1252?Q?OhFVBE73w6Q4NWuvsXol8DvmCfGf2LFG3Rx+xbYq3lxtX9WFcNYXS4hF?= =?Windows-1252?Q?fleM9R18fwoOz5P4INJ1KUygpQVMLTHSxUE4zfmXEmCd+JybS4TANj1M?= =?Windows-1252?Q?ljalXDZHX8CHKM1Oh5giKo/l1JdBMBd+AgrqLPR9sn4Z4gut6ZSDFyYz?= =?Windows-1252?Q?VcQz2MNtCvQAJ5/L312ztlVlfCFLBFnGgq/PtzyaDqwJKrawodzV2+cp?= =?Windows-1252?Q?IskUC1C+wDCPESDbhjAvZc2POGlLpkz5J3mXVwlYb6UOVpDYTFEvSQBQ?= =?Windows-1252?Q?Twe6L8qf9WI3gYGUSrE2ICdGyggszB5lpHz7O7GZjyV8/Q8HQ456/pqi?= =?Windows-1252?Q?05mhzfy6FnhjIoJ5sBUuYYzAVWbp6e2iQqWgx85l6gYUkmJHDsnWF2E7?= =?Windows-1252?Q?VyaCxXvrdVFxl7wy/Hy4mvkcSdwXJvFimNi0pPIOS99wDPgr62QdLJZT?= =?Windows-1252?Q?qWZqYTu5jFMsep08vfvPc0rm8XLJetsZQ//VN5uxZgIXArQFI1kY/OmR?= =?Windows-1252?Q?LsLzQts+JGJAuLWyVLfaXC8Hd1ToXqGgMbhhpKJpxeIZxYy9xh5aT7Md?= =?Windows-1252?Q?FP4Gu3Jo8KL+6WFUEuwAmr7oqkLZy8zQlpQ4R3oMqVYs3CJVQ63v3f7x?= =?Windows-1252?Q?gaTlD+xlMCa4zUMs/uhr41OmQ91ZRs/eIc5nAjB6x0TmRGnzPUwMO1ZM?= =?Windows-1252?Q?D+5VR8tbF4gyARKOKGkWFU1/k3dJi3NZpEAdXka0H0Rfxt8sQcOjuhtY?= =?Windows-1252?Q?ZD/+3au4pPX6lRGj3T3k1+ucLIwGmXnxtKQXj/tB9CN0oQ2RZ5mkoO1k?= =?Windows-1252?Q?Ie+nvD8Tyb05EGgC1G30ux9lm6vcYoJkzVqyPxQ0eydn5syYv56dz9oO?= =?Windows-1252?Q?zMzPGAvd1GEmus88YG2O8sodtVC4I+gYF9FDYT1PVyzM+9c3J0MtRpaJ?= =?Windows-1252?Q?ATxgCXXTnwcku0Kyd89UJXg0QKsZvE+0y6MCyK5a6tYLmR6McIr1IuIs?= =?Windows-1252?Q?Z2DfYqBViAQNyTLG+u2dEhANemMiULqe7Z0ruOykqsxf1PhN7RIz8u/B?= =?Windows-1252?Q?Tu/5ZHkaG5S5XylCmqLXOk8kiKRcb6cOFMx3B7P7Uxx6qxIeSR+bQTFr?= =?Windows-1252?Q?vDZpZ09LUo5tY0to6JhoGXBYS669tuXrUPxj3YbTPwy6VsingdgYrbDF?= =?Windows-1252?Q?lR9862QQNWOk/Pjt/v5pe3tLclph/Ysy3iyGcqPTSk40wW8AElQtkq06?= =?Windows-1252?Q?jyZCun7vLlJ3WINS8Cw25TvEcWzXWrJlSbiEIaY3NNJ+/ckE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;6:C+9K/LkxDIpVNnKG2ZiziQevKgvNiuV967M+sPCU1/RgsD6UeiTt883A0pkwjbIG8Z/OMu4cl7Hf1EtTJ1kvfXEG2wmzvh0Kywh/mFg6rgHKjoUzNXymoHe8kmA+PKABbWiwifLydbAqokx7yUKZWI8xJqzDLzTEDQDJJijESS8Ks2buB17oE6pc2TpChZ0jOTxQXU0pEPLuXOepLILczyjhLwon78kHMhckfvd/iFV9izvy630PD2WFXzrrOye1sTX4TcQLXwggMEC/XDRw7vUPcbK0xGvVk25DfegP0xVr5e6zbB75MWkERNFJ54JQKJufQscNvdS1yITDoqRQRLaSt1VAqcZDhF1n3/YONIj5HohC/K5AhnrqXwOmU09U;5:2has8DiJq+jwWQvaiNplJ7uEiy7PZDOVAW8MiGrNMB83qwmBwfberOX+rgg8ZbXkKl/cYSvnz/4H2IkYdGED4PK2t3PY0l5tod6ZAqjvRqTl8KWeifE0mAWsX7QOFvUDzh0ZZ8u0e8tMI1V6s3iC4w==;24:wJ91sbIOAjfIf/Y+1YJUolX8ac9Dx7gM77udMvCmcPSZaiC2upTu0JjROWaembX7G8FgYVyr5yK9uODWymvTzDUdhaA7IzhiPu7RJFOsuPg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;7:0FurmOt9t/kWki9Nu6p/XfrPtRwb1mCYrWOfNchTqC0ijegUzQglMtDGzvg5S8vA/YjjUSjz4TsoiETEC2vORhiTxyV4asUkok9vr/MjuNtmBI/BXYtF72AGzblycJ0x+jCKNOsbJUmw0R4zfXq4ahzuXyPfxWCZVyMRGSq8YI9rVdNy5YslADyKOZNkJkpo0/ozDCwt8bjVBia0WCkzF1qb2ly4mHh1kmiT7bYJ1Eo/qdJzbpPCBg0SLstZm9LLztyl8s1/r2dcfnIuL8n9KjTeUTbRZCcVwJ2jjdKWS0mEBSlNeww60fT3VNGwlXuoeY5wEgXezJPcey3wxuechJ9pADwXAmctFV4qu8MtiEM= X-OriginatorOrg: adaptrum.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 16:44:34.6751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0401MB1169 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2016 05:50 AM, Andrew Lunn wrote: > On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: >> With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The >> VSC8601 can handle this internally. While the VSC8601 can set more >> fine-grained delays, the standard skew settings work out of the box. >> The same heuristic is used to determine when this skew should be enabled >> as in vsc824x_config_init(). >> >> +/* This adds a skew for both TX and RX clocks, so the skew should only be >> + * applied to "rgmii-id" interfaces. It may not work as expected >> + * on "rgmii-txid", "rgmii-rxid" or "rgmii" interfaces. */ > > Hi Alexandru > > You should be able to make "rgmii" work as expected. If that is the > phy mode, disable the skew. And that's exactly the implemented behavior. See vsc8601_config_init() below. Alex