From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org, mike.kravetz@oracle.com,
naoya.horiguchi@nec.com
Cc: ying.huang@intel.com, hch@lst.de, dhowells@redhat.com,
cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mm/migration: return errno when isolate_huge_page failed
Date: Fri, 29 Apr 2022 12:08:56 +0200 [thread overview]
Message-ID: <f06e4a39-39e7-44de-dbc8-dc82ead37047@redhat.com> (raw)
In-Reply-To: <20220425132723.34824-4-linmiaohe@huawei.com>
On 25.04.22 15:27, Miaohe Lin wrote:
> We might fail to isolate huge page due to e.g. the page is under migration
> which cleared HPageMigratable. So we should return -EBUSY in this case
> rather than always return 1 which could confuse the user. Also we make
> the prototype of isolate_huge_page consistent with isolate_lru_page to
> improve the readability.
>
> Fixes: e8db67eb0ded ("mm: migrate: move_pages() supports thp migration")
If this is a fix, what's the runtime effect of it?
You state "could confuse", which doesn't indicate an actual BUG to me.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-04-29 10:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:27 [PATCH v2 0/4] A few cleanup and fixup patches for migration Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 1/4] mm/migration: reduce the rcu lock duration Miaohe Lin
2022-04-29 9:54 ` David Hildenbrand
2022-05-09 3:14 ` Miaohe Lin
2022-05-24 12:36 ` Miaohe Lin
2022-05-06 3:23 ` ying.huang
2022-05-09 3:20 ` Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 2/4] mm/migration: remove unneeded lock page and PageMovable check Miaohe Lin
2022-04-29 10:07 ` David Hildenbrand
2022-05-09 8:51 ` Miaohe Lin
2022-05-11 15:23 ` David Hildenbrand
2022-05-12 2:25 ` Miaohe Lin
2022-05-12 7:10 ` David Hildenbrand
2022-05-12 13:26 ` Miaohe Lin
2022-05-12 16:50 ` David Hildenbrand
2022-05-16 2:44 ` Miaohe Lin
2022-05-31 11:59 ` David Hildenbrand
2022-05-31 12:37 ` Miaohe Lin
2022-06-01 10:31 ` David Hildenbrand
2022-06-02 7:40 ` Miaohe Lin
2022-06-02 8:47 ` David Hildenbrand
2022-06-07 2:20 ` Miaohe Lin
2022-06-08 10:05 ` David Hildenbrand
2022-06-08 13:31 ` Miaohe Lin
2022-05-24 12:47 ` Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 3/4] mm/migration: return errno when isolate_huge_page failed Miaohe Lin
2022-04-29 10:08 ` David Hildenbrand [this message]
2022-05-09 8:03 ` Miaohe Lin
2022-04-29 11:36 ` Muchun Song
2022-05-09 3:23 ` Miaohe Lin
2022-05-09 4:21 ` Muchun Song
2022-05-09 7:51 ` Miaohe Lin
2022-04-25 13:27 ` [PATCH v2 4/4] mm/migration: fix potential pte_unmap on an not mapped pte Miaohe Lin
2022-04-29 9:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f06e4a39-39e7-44de-dbc8-dc82ead37047@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).