From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757999AbcIWJpP (ORCPT ); Fri, 23 Sep 2016 05:45:15 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:50988 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757409AbcIWJpM (ORCPT ); Fri, 23 Sep 2016 05:45:12 -0400 X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 12D2A261B3D Subject: Re: [PATCH 00/14] GPU-DRM-TTM: Fine-tuning for several function implementations To: SF Markus Elfring , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Emil Velikov References: <566ABCD9.1060404@users.sourceforge.net> <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Fri, 23 Sep 2016 11:44:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First of all please stop sending your patches as a reply to an earlier and completely unrelated series. Second please prefix all TTM related patches with "drm/ttm:". Additional to that I don't really see the point in renaming some of the jump labels, if you call it "restart" or "lock_restart" doesn't make much difference. Regards, Christian. Am 22.09.2016 um 19:32 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Thu, 22 Sep 2016 19:00:01 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): > Use kmalloc_array() in two functions > Rename a jump label in ttm_alloc_new_pages() > Rename jump labels in ttm_page_pool_free() > Rename a jump label in ttm_page_pool_get_pages() > Use kmalloc_array() in two more functions > Rename a jump label in ttm_dma_pool_alloc_new_pages() > Rename jump labels in ttm_dma_page_pool_free() > Rename a jump label in ttm_dma_pool_shrink_scan() > Return directly after a failed kzalloc() in ttm_dma_page_alloc_init() > Return directly after a failed kobject_init_and_add() in ttm_dma_page_alloc_init() > Return an error code only as a constant in ttm_dma_pool_init() > Less function calls in ttm_dma_pool_init() after error detection > Delete unnecessary variable initialisations in ttm_dma_pool_init() > Mark an array of text strings as "const" in ttm_dma_pool_init() > > drivers/gpu/drm/ttm/ttm_page_alloc.c | 30 ++++++++--------- > drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 58 +++++++++++++++----------------- > 2 files changed, 42 insertions(+), 46 deletions(-) >