linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Anand Moon <linux.amoon@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Date: Mon, 26 Jul 2021 10:06:02 +0200	[thread overview]
Message-ID: <f07da67e-3d67-85a5-699d-d528212a867f@baylibre.com> (raw)
In-Reply-To: <CAFBinCDaiu-tuo654_UTmxb0yeqQ8YqxCC7oVxq1EU4AmQRQdA@mail.gmail.com>

Hi,

On 08/07/2021 14:58, Martin Blumenstingl wrote:
> On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>>
>> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I think there's a typo here: observer -> observe
> maybe Kevin or Neil can fix this up (in this and the following two
> patches) while applying the patch so you don't have to re-spin a v3

Fixed while applying !

> 
>> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
>> instead of dummy regulator.
>>
>> [    7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
>> [    7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
>> [    7.117184] VCCK: supplied by regulator-dummy
>> [    7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
>> [    7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
>> [    7.118498] VDDEE: will resolve supply early: pwm
>> [    7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
>> [    7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
>> [    7.118553] VDDEE: supplied by regulator-dummy
>> [    7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>>
>> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
>> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>>
>> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 

Neil

  reply	other threads:[~2021-07-26  8:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:23 [PATCHv2 0/3] Fix the pwm regulator supply properties Anand Moon
2021-07-05 11:23 ` [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: " Anand Moon
2021-07-08 12:58   ` Martin Blumenstingl
2021-07-26  8:06     ` Neil Armstrong [this message]
2021-07-05 11:23 ` [PATCHv2 2/3] ARM: dts: meson8b: mxq: " Anand Moon
2021-07-08 12:58   ` Martin Blumenstingl
2021-07-05 11:23 ` [PATCHv2 3/3] ARM: dts: meson8b: ec100: " Anand Moon
2021-07-08 12:58   ` Martin Blumenstingl
2021-07-26  8:12 ` [PATCHv2 0/3] " Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07da67e-3d67-85a5-699d-d528212a867f@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).