linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jani Nikula <jani.nikula@intel.com>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: ksummit-discuss@lists.linuxfoundation.org,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	vishal.l.verma@intel.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stfrench@microsoft.com, Greg KH <gregkh@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	"Tobin C. Harding" <me@tobin.cc>
Subject: Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile
Date: Fri, 16 Nov 2018 09:56:59 -0800	[thread overview]
Message-ID: <f08820b05467cc95cc195a2639595c0274c95d69.camel@perches.com> (raw)
In-Reply-To: <878t1tgpk8.fsf@intel.com>

On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote:
> I quickly cooked up this script to produce the top-5 commit prefixes for
> the given files over the arbitrary last 200 commits. It'll give you a
> pretty good idea if you're even close.
> 
> ---
> #!/bin/sh
> # usage: subject-prefix FILE [...]
> # show top 5 subject prefixes for FILEs
> 
> git log --format=%s -n 200 -- "$@" |\
> 	grep -v "^Merge " |\
> 	sed 's/\(.*\):.*/\1/' |\
> 	sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\
> 	head -n 5
> ---
> 
> Someone who knows perl could turn that into a checkpatch check: See if
> the patch subject prefix is one of the top-5 for all files changed by
> the patch, and ask the user to double check if it isn't. Or some
> heuristics thereof.

This won't work when a patch contains multiple files
from different paths, or even multiple files from a
single driver.

Perhaps it's better to use a generic mechanism like

	basename $(dirname $filename):

with some exceptions and add an override patch subject
grammar to appropriate various sections of MAINTAINERS.

I also think it's better to use a separate script like
scripts/spdxcheck.py and tie any necessary checkpatch
use to that script.




  reply	other threads:[~2018-11-16 17:57 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  4:53 [RFC PATCH 0/3] Maintainer Handbook: Subsystem Profile Dan Williams
2018-11-15  4:53 ` [RFC PATCH 1/3] MAINTAINERS: Reclaim the P: tag for " Dan Williams
2018-11-15  5:39   ` [Ksummit-discuss] " Mauro Carvalho Chehab
2018-11-15 20:12     ` Joe Perches
2018-11-15  4:53 ` [RFC PATCH 2/3] MAINTAINERS, Handbook: " Dan Williams
2018-11-15  5:48   ` [Ksummit-discuss] " Julia Lawall
2018-11-15  7:59     ` Geert Uytterhoeven
2018-11-15 13:47       ` Julia Lawall
2018-11-16 12:44         ` Jani Nikula
2018-11-16 17:56           ` Joe Perches [this message]
2018-11-17 14:12             ` Rob Herring
2018-11-17 17:03               ` Julia Lawall
2018-11-20  7:28             ` Jani Nikula
2018-11-15  5:49   ` Mauro Carvalho Chehab
2018-11-15  7:58   ` Geert Uytterhoeven
2018-11-15  8:38   ` Jani Nikula
2018-11-15 18:03     ` Tim.Bird
2018-11-15 23:56     ` Tobin C. Harding
2018-11-15 15:44   ` Mauro Carvalho Chehab
2018-11-16 23:28     ` Randy Dunlap
2018-11-17 11:57     ` Hans Verkuil
2018-11-16  0:11   ` Frank Rowand
2018-11-16 12:04     ` Mauro Carvalho Chehab
2018-11-16 18:57       ` Dan Williams
2018-11-18 12:58         ` Mauro Carvalho Chehab
2018-11-18 17:31           ` Dan Williams
2018-11-18 17:31             ` Dan Williams
2018-11-18 17:34               ` Dan Williams
2018-11-18 17:44                 ` Mauro Carvalho Chehab
2018-11-16 16:47     ` Frank Rowand
2018-11-15  4:53 ` [RFC PATCH 3/3] libnvdimm, MAINTAINERS: " Dan Williams
2018-11-15  8:03   ` [Ksummit-discuss] " Geert Uytterhoeven
2018-11-15 14:10     ` Mauro Carvalho Chehab
2018-11-15 16:20       ` Leon Romanovsky
2018-11-15 19:09         ` Mauro Carvalho Chehab
2018-11-15 19:35           ` Leon Romanovsky
2018-11-15 19:40             ` Luck, Tony
2018-11-15 19:43               ` Joe Perches
2018-11-16 11:39                 ` Mauro Carvalho Chehab
2018-11-18  7:12                   ` Leon Romanovsky
2018-11-16 11:33             ` Mauro Carvalho Chehab
2018-11-16 12:00               ` Jan Kara
2018-11-18  7:00               ` Leon Romanovsky
2018-11-16 20:36         ` Rodrigo Vivi
2018-11-16 23:44           ` Dan Williams
2018-11-17  0:38             ` NeilBrown
2018-11-18 13:11               ` Mauro Carvalho Chehab
2018-11-18 13:03             ` Mauro Carvalho Chehab
2018-11-20  8:10               ` Jani Nikula
2018-11-20 19:31                 ` Dan Williams
2018-11-26 11:12                 ` Mauro Carvalho Chehab
2018-11-26 15:55                   ` Joe Perches
2018-11-16 19:13     ` Dan Williams
2018-11-15 14:30   ` Mauro Carvalho Chehab
2018-11-15 14:51     ` Julia Lawall
2018-11-16 19:20     ` Dan Williams
2018-11-16  2:58   ` y-goto
2018-11-17  0:32   ` [Ksummit-discuss] " David Woodhouse
2018-11-15  5:56 ` [RFC PATCH 0/3] Maintainer Handbook: " Mauro Carvalho Chehab
2018-11-25 10:57 ` Pavel Machek
2018-11-25 20:55   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f08820b05467cc95cc195a2639595c0274c95d69.camel@perches.com \
    --to=joe@perches.com \
    --cc=dvyukov@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jani.nikula@intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mchehab@kernel.org \
    --cc=me@tobin.cc \
    --cc=stfrench@microsoft.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).