From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B689C433B4 for ; Tue, 11 May 2021 14:31:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E8E613C3 for ; Tue, 11 May 2021 14:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbhEKOcu convert rfc822-to-8bit (ORCPT ); Tue, 11 May 2021 10:32:50 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]:58028 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbhEKOct (ORCPT ); Tue, 11 May 2021 10:32:49 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-32-ksxxKfZ1MOGdNqOWBkuFfw-1; Tue, 11 May 2021 15:31:40 +0100 X-MC-Unique: ksxxKfZ1MOGdNqOWBkuFfw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 11 May 2021 15:31:38 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Tue, 11 May 2021 15:31:38 +0100 From: David Laight To: 'Petr Mladek' CC: 'Steven Rostedt' , 'Stephen Boyd' , Andrew Morton , "linux-kernel@vger.kernel.org" , "Alexei Starovoitov" , Andy Shevchenko , Baoquan He , "Borislav Petkov" , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , "kexec@lists.infradead.org" , Konstantin Khlebnikov , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , Matthew Wilcox , "Rasmus Villemoes" , Sasha Levin , Sergey Senozhatsky , Thomas Gleixner , Vivek Goyal , Will Deacon , "x86@kernel.org" , Christoph Hellwig , peter enderborg Subject: RE: [PATCH v6 00/13] Add build ID to stacktraces Thread-Topic: [PATCH v6 00/13] Add build ID to stacktraces Thread-Index: AQHXRf4HnT90HedmH0WFx6bjKadex6reN/jQ///0T4CAABGGcIAAB3WAgAASvAA= Date: Tue, 11 May 2021 14:31:38 +0000 Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511085235.09bc38a7@gandalf.local.home> <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Petr Mladek > Sent: 11 May 2021 15:22 > > On Tue 2021-05-11 12:58:47, David Laight wrote: > > From: Steven Rostedt > > > Sent: 11 May 2021 13:53 > > > > > > On Tue, 11 May 2021 12:36:06 +0000 > > > David Laight wrote: > > > > > > > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0 > > > > > Call trace: > > > > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > > full_proxy_write+0x74/0xa4 > > > > > > > > Is there any way to get it to print each module ID only once? > > > > > > If there's a trivial way to do that, then perhaps it should be done, but for > > > now, this patch series isn't as obnoxious as the previous versions. It only > > > affects stack traces, and I'm fine with that. > > > > True. Printing the id in the module list was horrid. > > > > The real downside is all the extra text that will overflow the > > in-kernel buffer. > > At least it shouldn't be extra lines causing screen wrap. > > Unless the variable names are long - hi rust :-) > > Note that the ID is printed only when CONFIG_STACKTRACE_BUILD_ID > is enabled. It will be used only by some distros/vendors that > use it to download the debuginfo packages. Until Ubuntu decide to turn it on :-) Actually, for the use case, the id could be trimmed significantly. It is only trying to differentiate between builds of a specific module. So even 8 digits would be plenty. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)