From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5391FC4320A for ; Fri, 30 Jul 2021 10:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3717C60F9B for ; Fri, 30 Jul 2021 10:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238591AbhG3K77 (ORCPT ); Fri, 30 Jul 2021 06:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:57900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238461AbhG3K76 (ORCPT ); Fri, 30 Jul 2021 06:59:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57F8D60F9B; Fri, 30 Jul 2021 10:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627642794; bh=7G8XPhtyHOsQOBrdu6AY5KW4NxFLaa/KplGrDdA8Mn8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=V4cT09UFGn1FlQxEKbRS4g0/ToJp5VmSrNF2NBcUrJpZgFuB6x+wrlDk73aQFX1aK uSzGtv7M6HwSE+4z2lPDhm9fZvKKbI1KvT4905okIknu/QdDnocaE8jHio/WJEVWtO jMu95MNGUiapvvaSsO6IAWncaL4K57Lrp5l+SKjq/dftKGT7gDC4scniEVPz8i6T9S U/++szs+4hiKF27XBJGiRx8M1jyJQ5KQrPN6W15HGf3+9gSdo5r5oXjv9tRr2wDygt yCFr+mYPGHK4SQJ5DCmWDOGJ16/jad5/yVZgI5RPA5JcPU5aaasFPSAsZ3wPK7GcvM Eh5eT88/SwdZw== Subject: Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused To: Tony Lindgren , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org References: <20210727101034.32148-1-tony@atomide.com> From: Roger Quadros Message-ID: Date: Fri, 30 Jul 2021 13:59:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210727101034.32148-1-tony@atomide.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/2021 13:10, Tony Lindgren wrote: > We want to clear any unused GPMC_CS_CONFIG7 register on restore to > ensure unused chip selects are not enabled. > > Cc: Roger Quadros > Signed-off-by: Tony Lindgren Acked-by: Roger Quadros Sorry if you got this twice. I got a bounce back on the previous Ack. cheers, -roger > --- > drivers/memory/omap-gpmc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void) > gpmc_context.cs_context[i].config6); > gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, > gpmc_context.cs_context[i].config7); > + } else { > + gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0); > } > } > } >