From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297AbeAMVIx (ORCPT + 1 other); Sat, 13 Jan 2018 16:08:53 -0500 Received: from mout.web.de ([212.227.15.4]:55458 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbeAMVIv (ORCPT ); Sat, 13 Jan 2018 16:08:51 -0500 Subject: Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list() To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: Bjorn Helgaas , LKML , kernel-janitors@vger.kernel.org References: <20180113000839.GD205469@bhelgaas-glaptop.roam.corp.google.com> <03f4a55c-3bc3-0f15-bfc4-73049861edc4@users.sourceforge.net> <20180113201709.GF205469@bhelgaas-glaptop.roam.corp.google.com> From: SF Markus Elfring Message-ID: Date: Sat, 13 Jan 2018 22:08:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180113201709.GF205469@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:+k9IjFtLBMYGOCjSpWMmJC/MIuKSp/rHQNGvok/lGWJPS5kI6Yc h1aidavn2b3yXridcPHKVedGjmf/mjsD7+1OTSHqWsIPhUrMa07tMgSqBwyqt4d1EZf3iO3 wAVe8wdLZDiycg+rYjOLLtAN1JVlX71Wo1CsOzTAShyWu/JmMoFfIYnKPKCelJb6GYhNqr8 55e58kzz2R0CyO5MT/vQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:eSoIec1EaJY=:7RgVClTJdrAkdH3csoL1TF 1pOWNT49jtV8ti1/UIfE/HDdcbyRLlzwzmza6M5IJk6n9l2gE9x0oSCZGMSNZyTTv1ms5MqJ2 aUyDv+MMHEn1K49TZYBrXrcJj9XBD7DFy/LeYLc3RGGlVlHZ8NSR/3Q+Ine0k3Wz7eHUIulYG mPM19M4xWUNIJQo78vywfwrDT322yG9tWIttbZlkKCFrVimCKMAFIxa7wYu9vc+T/D/Glf8+f BANFzJIqa/WsaFq9Xew9Ljrx4wq4sxViPVSNA2CQANu1XNMAtLHIXNCJP6o1EY2agf15/L2cv kCkN7bQPrJqVCAVZou8RBNwscprcUPMZIiqeBRt8C4KTJshu/SmxigMT71zfum6zICUpu9eaR kaARD2LGgR8PP+1o7O2AYmDv1fiSVQCqi2JE/8lNWJvUwX0dJjZviV2QO7TkB4/pT+giwb+Gi mx5BwU+8FvUlb2irbe03yifHhqhgXv/BirHk0O69i1Gk0WypWmuQGt4gentHawOZtgljVxVQM crIzR+G6W+39S4jefExEbxNSWgvmq1yke0gSFDhEyN+2WTtLfsB+QH/llgUCGATZEaaPkARn1 ukC3tauRYMPoOp0sGIuDFaJPQjgTvOlvxmKnYR60XEhG35myyHklkm6GkGWXW0MTSTK8ikmTn AW/bX18Ywob+m6adXGzTgCvl3nt2H+mS1t3sfv8ZDPDRYArOHiQaRjuBBjIaP/nEuzD+2u9tS dFltlhgLL9v7SLqR+VMmp8sdTliC9Z/c9XbV17DddjegeBNbt0a+C2JNTHRaUWuqyEW61YTSH uKxzngAtEvJH2/Or3nEw2OiRX8PjGw0qKZrPeZ81WNM9U6+4qM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > Your commit message says "omit an extra message", which suggests that > there are currently two messages about the memory allocation failure, > and that your patch removes one of them. Yes. - There is a general transformation pattern applied. > If that's the case, it would be nice to know where the other message is. Have you got any special experiences with backtraces? > If your patch removes the *only* message about the memory allocation > failure, that might be worth doing, Thanks for a bit of positive feedback. > but the changelog should be clear about that Do you distinguish the “log” from a commit description? > and say "I don't think the error message is worthwhile > because the function already returns failure" or something similar. Do you find the wording “WARNING: Possible unnecessary 'out of memory' message” (from the script “checkpatch.pl”) more reasonable? >> * Are you looking for a reminder on the Linux allocation failure report? > > I don't know what the "Linux allocation failure report" is. This information seems to be “hidden” in source code. https://elixir.free-electrons.com/linux/v4.15-rc7/source/include/linux/gfp.h#L191 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/gfp.h?id=c92a9a461dff6140c539c61e457aa97df29517d6#n213 Are you familiar with the usage of the option “__GFP_NOWARN”? >>> Also, please squash all the drivers/pci patches into one. >> >> To which other change possibilities do you refer here? > > You posted two patches that remove error messages about memory > allocation failures: Yes. - Also for this software area … > http://lkml.kernel.org/r/dc3922b4-50f6-e7fa-482f-18e6ff5d905f@users.sourceforge.net Is it safer to handle adjustments for the directory “drivers/pci/hotplug” separately? > http://lkml.kernel.org/r/fd9d212e-e8da-1aa7-be7f-7bf6d8f1e15f@users.sourceforge.net > > These are doing the same thing and could be combined into one patch. The final committer could perform such an operation if an other patch granularity would be preferred (or if you would insist on patch squashing). I guess that you do not need to wait on me to apply an adjusted software combination in this case. Regards, Markus