From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Benjamin Stürz" <benni@stuerz.xyz>, andrew@lunn.ch
Cc: <sebastian.hesselbarth@gmail.com>, <gregory.clement@bootlin.com>,
<linux@armlinux.org.uk>, <linux@simtec.co.uk>, <krzk@kernel.org>,
<alim.akhtar@samsung.com>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
<hpa@zytor.com>, <robert.moore@intel.com>,
<rafael.j.wysocki@intel.com>, <lenb@kernel.org>,
<3chas3@gmail.com>, <laforge@gnumonks.org>, <arnd@arndb.de>,
<gregkh@linuxfoundation.org>, <mchehab@kernel.org>,
<tony.luck@intel.com>, <james.morse@arm.com>, <rric@kernel.org>,
<linus.walleij@linaro.org>, <brgl@bgdev.pl>,
<mike.marciniszyn@cornelisnetworks.com>,
<dennis.dalessandro@cornelisnetworks.com>, <jgg@ziepe.ca>,
<pali@kernel.org>, <dmitry.torokhov@gmail.com>,
<isdn@linux-pingi.de>, <benh@kernel.crashing.org>,
<fbarrat@linux.ibm.com>, <ajd@linux.ibm.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<nico@fluxnic.net>, <loic.poulain@linaro.org>, <kvalo@kernel.org>,
<pkshih@realtek.com>, <bhelgaas@google.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>, <linux-ia64@vger.kernel.org>,
<linux-acpi@vger.kernel.org>, <devel@acpica.org>,
<linux-atm-general@lists.sourceforge.net>,
<netdev@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-input@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-media@vger.kernel.org>, <wcn36xx@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 19/22] wnc36xx: Replace comments with C99 initializers
Date: Mon, 28 Mar 2022 09:17:40 -0700 [thread overview]
Message-ID: <f0ebc901-051a-c7fe-ca5a-bc798e7c31e7@quicinc.com> (raw)
In-Reply-To: <20220326165909.506926-19-benni@stuerz.xyz>
On 3/26/2022 9:59 AM, Benjamin Stürz wrote:
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
>
> Signed-off-by: Benjamin Stürz <benni@stuerz.xyz>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 122 ++++++++++++------------
> 1 file changed, 61 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 95ea7d040d8c..0fed64bd37b4 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -193,67 +193,67 @@ static inline u8 get_sta_index(struct ieee80211_vif *vif,
> }
>
> static const char * const wcn36xx_caps_names[] = {
> - "MCC", /* 0 */
> - "P2P", /* 1 */
> - "DOT11AC", /* 2 */
> - "SLM_SESSIONIZATION", /* 3 */
> - "DOT11AC_OPMODE", /* 4 */
> - "SAP32STA", /* 5 */
> - "TDLS", /* 6 */
> - "P2P_GO_NOA_DECOUPLE_INIT_SCAN",/* 7 */
> - "WLANACTIVE_OFFLOAD", /* 8 */
> - "BEACON_OFFLOAD", /* 9 */
> - "SCAN_OFFLOAD", /* 10 */
> - "ROAM_OFFLOAD", /* 11 */
> - "BCN_MISS_OFFLOAD", /* 12 */
> - "STA_POWERSAVE", /* 13 */
> - "STA_ADVANCED_PWRSAVE", /* 14 */
> - "AP_UAPSD", /* 15 */
> - "AP_DFS", /* 16 */
> - "BLOCKACK", /* 17 */
> - "PHY_ERR", /* 18 */
> - "BCN_FILTER", /* 19 */
> - "RTT", /* 20 */
> - "RATECTRL", /* 21 */
> - "WOW", /* 22 */
> - "WLAN_ROAM_SCAN_OFFLOAD", /* 23 */
> - "SPECULATIVE_PS_POLL", /* 24 */
> - "SCAN_SCH", /* 25 */
> - "IBSS_HEARTBEAT_OFFLOAD", /* 26 */
> - "WLAN_SCAN_OFFLOAD", /* 27 */
> - "WLAN_PERIODIC_TX_PTRN", /* 28 */
> - "ADVANCE_TDLS", /* 29 */
> - "BATCH_SCAN", /* 30 */
> - "FW_IN_TX_PATH", /* 31 */
> - "EXTENDED_NSOFFLOAD_SLOT", /* 32 */
> - "CH_SWITCH_V1", /* 33 */
> - "HT40_OBSS_SCAN", /* 34 */
> - "UPDATE_CHANNEL_LIST", /* 35 */
> - "WLAN_MCADDR_FLT", /* 36 */
> - "WLAN_CH144", /* 37 */
> - "NAN", /* 38 */
> - "TDLS_SCAN_COEXISTENCE", /* 39 */
> - "LINK_LAYER_STATS_MEAS", /* 40 */
> - "MU_MIMO", /* 41 */
> - "EXTENDED_SCAN", /* 42 */
> - "DYNAMIC_WMM_PS", /* 43 */
> - "MAC_SPOOFED_SCAN", /* 44 */
> - "BMU_ERROR_GENERIC_RECOVERY", /* 45 */
> - "DISA", /* 46 */
> - "FW_STATS", /* 47 */
> - "WPS_PRBRSP_TMPL", /* 48 */
> - "BCN_IE_FLT_DELTA", /* 49 */
> - "TDLS_OFF_CHANNEL", /* 51 */
> - "RTT3", /* 52 */
> - "MGMT_FRAME_LOGGING", /* 53 */
> - "ENHANCED_TXBD_COMPLETION", /* 54 */
> - "LOGGING_ENHANCEMENT", /* 55 */
> - "EXT_SCAN_ENHANCED", /* 56 */
> - "MEMORY_DUMP_SUPPORTED", /* 57 */
> - "PER_PKT_STATS_SUPPORTED", /* 58 */
> - "EXT_LL_STAT", /* 60 */
> - "WIFI_CONFIG", /* 61 */
> - "ANTENNA_DIVERSITY_SELECTION", /* 62 */
> + [0] = "MCC",
> + [1] = "P2P",
> + [2] = "DOT11AC",
> + [3] = "SLM_SESSIONIZATION",
> + [4] = "DOT11AC_OPMODE",
> + [5] = "SAP32STA",
> + [6] = "TDLS",
> + [7] = "P2P_GO_NOA_DECOUPLE_INIT_SCAN",
> + [8] = "WLANACTIVE_OFFLOAD",
> + [9] = "BEACON_OFFLOAD",
> + [10] = "SCAN_OFFLOAD",
> + [11] = "ROAM_OFFLOAD",
> + [12] = "BCN_MISS_OFFLOAD",
> + [13] = "STA_POWERSAVE",
> + [14] = "STA_ADVANCED_PWRSAVE",
> + [15] = "AP_UAPSD",
> + [16] = "AP_DFS",
> + [17] = "BLOCKACK",
> + [18] = "PHY_ERR",
> + [19] = "BCN_FILTER",
> + [20] = "RTT",
> + [21] = "RATECTRL",
> + [22] = "WOW",
> + [23] = "WLAN_ROAM_SCAN_OFFLOAD",
> + [24] = "SPECULATIVE_PS_POLL",
> + [25] = "SCAN_SCH",
> + [26] = "IBSS_HEARTBEAT_OFFLOAD",
> + [27] = "WLAN_SCAN_OFFLOAD",
> + [28] = "WLAN_PERIODIC_TX_PTRN",
> + [29] = "ADVANCE_TDLS",
> + [30] = "BATCH_SCAN",
> + [31] = "FW_IN_TX_PATH",
> + [32] = "EXTENDED_NSOFFLOAD_SLOT",
> + [33] = "CH_SWITCH_V1",
> + [34] = "HT40_OBSS_SCAN",
> + [35] = "UPDATE_CHANNEL_LIST",
> + [36] = "WLAN_MCADDR_FLT",
> + [37] = "WLAN_CH144",
> + [38] = "NAN",
> + [39] = "TDLS_SCAN_COEXISTENCE",
> + [40] = "LINK_LAYER_STATS_MEAS",
> + [41] = "MU_MIMO",
> + [42] = "EXTENDED_SCAN",
> + [43] = "DYNAMIC_WMM_PS",
> + [44] = "MAC_SPOOFED_SCAN",
> + [45] = "BMU_ERROR_GENERIC_RECOVERY",
> + [46] = "DISA",
> + [47] = "FW_STATS",
> + [48] = "WPS_PRBRSP_TMPL",
> + [49] = "BCN_IE_FLT_DELTA",
> + [51] = "TDLS_OFF_CHANNEL",
> + [52] = "RTT3",
> + [53] = "MGMT_FRAME_LOGGING",
> + [54] = "ENHANCED_TXBD_COMPLETION",
> + [55] = "LOGGING_ENHANCEMENT",
> + [56] = "EXT_SCAN_ENHANCED",
> + [57] = "MEMORY_DUMP_SUPPORTED",
> + [58] = "PER_PKT_STATS_SUPPORTED",
> + [60] = "EXT_LL_STAT",
> + [61] = "WIFI_CONFIG",
> + [62] = "ANTENNA_DIVERSITY_SELECTION",
> };
>
> static const char *wcn36xx_get_cap_name(enum place_holder_in_cap_bitmap x)
I know there has been much discussion on this series. For this specific
patch this would be a great change if you use the actual enumerations
from enum place_holder_in_cap_bitmap as the index values,
i.e.
[MCC] = "MCC",
etc.
So a v2 for this patch would be appreciated
next prev parent reply other threads:[~2022-03-28 16:17 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 16:58 [PATCH 01/22] orion5x: Replace comments with C99 initializers Benjamin Stürz
2022-03-26 16:58 ` [PATCH 02/22] s3c: " Benjamin Stürz
2022-03-26 19:44 ` Joe Perches
2022-03-28 13:37 ` Daniel Thompson
2022-03-26 16:58 ` [PATCH 03/22] ia64: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 04/22] x86: " Benjamin Stürz
2022-03-28 23:08 ` Thomas Gleixner
2022-03-26 16:58 ` [PATCH 05/22] acpica: " Benjamin Stürz
2022-03-27 19:59 ` Andy Shevchenko
2022-03-31 19:27 ` Moore, Robert
2022-04-01 5:09 ` Christoph Hellwig
2022-04-01 5:10 ` Christoph Hellwig
2022-03-28 12:33 ` Rafael J. Wysocki
2022-03-26 16:58 ` [PATCH 06/22] idt77252: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 07/22] cm4000: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 08/22] i5100: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 09/22] gpio-winbond: Use " Benjamin Stürz
2022-03-27 12:03 ` Linus Walleij
2022-03-29 12:30 ` Bartosz Golaszewski
2022-03-26 16:58 ` [PATCH 10/22] hfi1: Replace comments with " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 11/22] rdmavt: " Benjamin Stürz
2022-03-27 7:04 ` Leon Romanovsky
2022-03-31 17:41 ` Dennis Dalessandro
2022-03-26 16:58 ` [PATCH 12/22] alps: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 13/22] capi: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 14/22] mISDN: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 15/22] macintosh: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 16/22] dvb-usb: " Benjamin Stürz
2022-03-26 18:24 ` Mauro Carvalho Chehab
2022-03-26 18:27 ` Mauro Carvalho Chehab
2022-03-26 19:51 ` Joe Perches
2022-03-26 20:11 ` Larry Finger
2022-03-26 21:08 ` Mauro Carvalho Chehab
2022-03-28 18:08 ` [PATCH 16/22 v3] " Benjamin Stürz
2022-03-28 20:52 ` Mauro Carvalho Chehab
2022-03-27 13:33 ` [PATCH 16/22 v2] " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 17/22] cxl: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 18/22] smsc: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 19/22] wnc36xx: " Benjamin Stürz
2022-03-28 16:17 ` Jeff Johnson [this message]
2022-03-28 18:38 ` [PATCH 19/22 v2] wcn36xx: Improve readability of wcn36xx_caps_name Benjamin Stürz
2022-03-28 20:23 ` Jeff Johnson
2022-03-30 7:05 ` Kalle Valo
2022-03-30 8:19 ` Kalle Valo
2022-03-26 16:59 ` [PATCH 20/22] wireless: Replace comments with C99 initializers Benjamin Stürz
2022-03-28 12:06 ` Kalle Valo
2022-03-28 18:21 ` [PATCH 20/22 v2] ray_cs: " Benjamin Stürz
2022-03-28 19:23 ` Joe Perches
2022-03-28 19:54 ` [PATCH 20/22 v3] ray_cs: Improve card_status[] Benjamin Stürz
2022-04-06 11:31 ` Kalle Valo
2022-03-26 16:59 ` [PATCH 21/22] rtw89: Replace comments with C99 initializers Benjamin Stürz
2022-03-26 18:55 ` Larry Finger
2022-03-28 9:28 ` Kalle Valo
2022-03-28 12:21 ` David Laight
2022-03-26 16:59 ` [PATCH 22/22] pci: " Benjamin Stürz
2022-03-26 18:20 ` [PATCH 01/22] orion5x: " Mauro Carvalho Chehab
2022-03-26 19:23 ` Arnd Bergmann
2022-03-28 13:19 ` Segher Boessenkool
2022-03-27 12:46 ` [PATCH 00/22] " Benjamin Stürz
2022-03-28 9:33 ` Kalle Valo
2022-03-28 11:51 ` Benjamin Stürz
2022-03-28 12:31 ` Kalle Valo
2022-03-28 20:20 ` Jakub Kicinski
2022-03-28 13:47 ` Daniel Thompson
2022-03-28 13:17 ` [PATCH 01/22] orion5x: " Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ebc901-051a-c7fe-ca5a-bc798e7c31e7@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=3chas3@gmail.com \
--cc=ajd@linux.ibm.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=benni@stuerz.xyz \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brgl@bgdev.pl \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devel@acpica.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hpa@zytor.com \
--cc=isdn@linux-pingi.de \
--cc=james.morse@arm.com \
--cc=jgg@ziepe.ca \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=laforge@gnumonks.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-edac@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@simtec.co.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pabeni@redhat.com \
--cc=pali@kernel.org \
--cc=pkshih@realtek.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).