From: Bert Kenward <bkenward@solarflare.com>
To: Huang Zijiang <huang.zijiang@zte.com.cn>,
<linux-net-drivers@solarflare.com>
Cc: <ecree@solarflare.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wang.yi59@zte.com.cn>
Subject: Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
Date: Thu, 14 Feb 2019 09:34:21 +0000 [thread overview]
Message-ID: <f0f1b6ea-9568-c3e9-a92e-43fc87d253c4@solarflare.com> (raw)
In-Reply-To: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn>
On 14/02/2019 06:42, Huang Zijiang wrote:
> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
> when skb is still used. The skb is be replaced by segments, so the
> original skb should be consumed(not drop).
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Sergei's commit message fixups look good, but apart from that:
Acked-by: Bert Kenward <bkenward@solarflare.com>
> ---
> drivers/net/ethernet/sfc/tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c3ad564..ed551f0 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
> if (IS_ERR(segments))
> return PTR_ERR(segments);
>
> - dev_kfree_skb_any(skb);
> + dev_consume_skb_any(skb);
> skb = segments;
>
> while (skb) {
>
next prev parent reply other threads:[~2019-02-14 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 6:42 [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
2019-02-14 9:13 ` Sergei Shtylyov
2019-02-14 9:34 ` Bert Kenward [this message]
2019-02-14 17:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f1b6ea-9568-c3e9-a92e-43fc87d253c4@solarflare.com \
--to=bkenward@solarflare.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=huang.zijiang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=wang.yi59@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).