From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file
Date: Wed, 11 Aug 2021 22:02:48 +0800 [thread overview]
Message-ID: <f0f98e37-2486-fe79-7950-0a117a59b303@linux.intel.com> (raw)
In-Reply-To: <YRPVfES0aTbfaHES@smile.fi.intel.com>
On 2021/8/11 21:49, Andy Shevchenko wrote:
> On Fri, Jul 30, 2021 at 09:01:41PM +0800, Lu Baolu wrote:
>> On 2021/7/30 16:05, Andy Shevchenko wrote:
>>> On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote:
>>>> On 7/30/21 12:35 AM, Andy Shevchenko wrote:
>>>>> Compiler is not happy about hidden declaration of intel_iommu_ops.
>>>>>
>>>>> .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
>>>>>
>>>>> Move declaration to header file to make compiler happy.
>>>>
>>>> Thanks for the cleanup. Sharing data structures between different files
>>>> doesn't seem to be a good design. How about adding a helper so that the
>>>> intel_iommu_ops could be a static one?
>>>
>>> Whatever suits the purpose.
>>> Can you apply patch 2 of this series, please?
>>>
>>
>> Yes, I will. Thanks!
>
> Gentle reminder.
>
Thanks. Normally I will queue the vt-d patches to Joerg in the rc6 week.
Best regards,
baolu
next prev parent reply other threads:[~2021-08-11 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 16:35 [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Andy Shevchenko
2021-07-29 16:35 ` [PATCH v1 2/2] iommu/vt-d: Drop the kernel doc annotation Andy Shevchenko
2021-07-30 2:20 ` [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Lu Baolu
2021-07-30 8:05 ` Andy Shevchenko
2021-07-30 13:01 ` Lu Baolu
2021-08-11 13:49 ` Andy Shevchenko
2021-08-11 14:02 ` Lu Baolu [this message]
2021-08-11 14:23 ` Andy Shevchenko
2021-10-06 16:14 ` Andy Shevchenko
2021-10-08 4:34 ` Lu Baolu
2021-10-08 11:59 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f98e37-2486-fe79-7950-0a117a59b303@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).