From: Marc Zyngier <marc.zyngier@arm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Parthiban Nallathambi <pn@denx.de>
Cc: tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org,
mark.rutland@arm.com, afaerber@suse.de, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
sravanhome@gmail.com, thomas.liau@actions-semi.com,
mp-cs@actions-semi.com, linux@cubietech.com,
edgar.righi@lsitec.org.br, laisa.costa@lsitec.org.br,
guilherme.simoes@lsitec.org.br, mkzuffo@lsi.usp.br
Subject: Re: [PATCH v2 1/3] dt-bindings: interrupt-controller: Actions external interrupt controller
Date: Mon, 13 Aug 2018 08:51:54 +0100 [thread overview]
Message-ID: <f1043a48-6c8d-cf08-d6a1-582d84ea2530@arm.com> (raw)
In-Reply-To: <20180813043406.GA16275@Mani-XPS-13-9360>
On 13/08/18 05:34, Manivannan Sadhasivam wrote:
> Hi Parthiban,
>
> On Sun, Aug 12, 2018 at 02:22:13PM +0200, Parthiban Nallathambi wrote:
>> Actions Semi OWL family SoC's provides support for external interrupt
>> controller to be connected and controlled using SIRQ pins. S500, S700
>> and S900 provides 3 SIRQ lines and works independently for 3 external
>> interrupt controllers.
>>
>> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>> ---
>> .../interrupt-controller/actions,owl-sirq.txt | 46 ++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>> new file mode 100644
>> index 000000000000..4b8437751331
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>> @@ -0,0 +1,46 @@
>> +Actions Semi Owl SoCs SIRQ interrupt controller
>> +
>> +S500, S700 and S900 SoC's from Actions provides 3 SPI's from GIC,
>> +in which external interrupt controller can be connected. 3 SPI's
>> +45, 46, 47 from GIC are directly exposed as SIRQ. It has
>> +the following properties:
>
> We should really document the driver here. What it does? and how the
> hierarchy is handled with GIC? etc...
Absolutely not. This should document the binding, irrespective of the
operating system. The word "driver" is completely out of place here.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-08-13 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 12:22 [PATCH v2 0/3] Add Actions Semi Owl family sirq support Parthiban Nallathambi
2018-08-12 12:22 ` [PATCH v2 1/3] dt-bindings: interrupt-controller: Actions external interrupt controller Parthiban Nallathambi
2018-08-13 4:34 ` Manivannan Sadhasivam
2018-08-13 7:51 ` Marc Zyngier [this message]
2018-08-13 9:15 ` Manivannan Sadhasivam
2018-08-13 9:23 ` Manivannan Sadhasivam
2018-11-12 10:53 ` Parthiban Nallathambi
2018-08-13 19:44 ` Rob Herring
2018-11-12 11:01 ` Parthiban Nallathambi
2018-08-12 12:22 ` [PATCH v2 2/3] drivers/irqchip: Add Actions external interrupts support Parthiban Nallathambi
2018-08-13 11:46 ` Marc Zyngier
2018-08-26 15:20 ` Parthiban Nallathambi
2018-09-20 9:42 ` Parthiban Nallathambi
2018-11-06 18:07 ` Parthiban Nallathambi
2018-11-08 17:03 ` Marc Zyngier
2018-11-12 10:32 ` Parthiban Nallathambi
2018-11-13 14:56 ` Marc Zyngier
2018-08-12 12:22 ` [PATCH v2 3/3] arm64: dts: actions: Add sirq node for Actions Semi S700 Parthiban Nallathambi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1043a48-6c8d-cf08-d6a1-582d84ea2530@arm.com \
--to=marc.zyngier@arm.com \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=guilherme.simoes@lsitec.org.br \
--cc=jason@lakedaemon.net \
--cc=laisa.costa@lsitec.org.br \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@cubietech.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mkzuffo@lsi.usp.br \
--cc=mp-cs@actions-semi.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.liau@actions-semi.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).