From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EF6C433EF for ; Sat, 9 Apr 2022 00:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240156AbiDIA32 (ORCPT ); Fri, 8 Apr 2022 20:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbiDIA3Y (ORCPT ); Fri, 8 Apr 2022 20:29:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D99326C2 for ; Fri, 8 Apr 2022 17:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F22496219F for ; Sat, 9 Apr 2022 00:27:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2435CC385A1; Sat, 9 Apr 2022 00:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649464038; bh=V21qrnxEGRvRtjsW99rzEkaJ71bW7eH7K1kylLcmTf0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=U8bMgHPG6hX+393ZLGBfvguEU8DygSp3aM4StKrSfwZVxbNMUnXZAJXCO5DegcZiL 9MuybHlEcyCpaw4EKK6p7b/VP7qz5xsa705aIzKEjpruhIMDSw5jVAcrY6Ce43+wVM PohWP2PPtXE5YDvYWibMDYnXZnJose0TPcQguA/nQo2qUubTejJDVDIK1xPeOOe6HQ dXYCZ74VIKeo2DL4ZyMZLHja2yBtXOEpbtat57L6H0OEYgY/8fOoUC6k74dlg1NXBS 0v3+3Xyepx6+kXaBJ11AYYerVnuDu2Vu/fOGcANrKu0j4TWcAlnLaDjxbqwapPljO6 ibyJuQ4BYajAQ== Message-ID: Date: Sat, 9 Apr 2022 08:27:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr Content-Language: en-US To: Dongliang Mu , Jaegeuk Kim Cc: Dongliang Mu , syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20220408052207.209856-1-dzm91@hust.edu.cn> From: Chao Yu In-Reply-To: <20220408052207.209856-1-dzm91@hust.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/8 13:22, Dongliang Mu wrote: > From: Dongliang Mu > > In f2fs_is_valid_blkaddr, if type is DATA_GENERIC_ENHANCE or > DATA_GENERIC_ENHANCE_READ, it invokes WARN_ON(1) not matter > blkaddr is in the range or not. If we run into the path where we invoke WARN_ON(1) in f2fs_is_valid_blkaddr(), It means f2fs image may be broken, or there is a bug in f2fs. So, do you suffer any related issue in your environment? Thanks, > > Fix this by removing WARN_ON. > > Note that, syzbot patch testing does not incur any further issues > > Reported-by: syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com > Signed-off-by: Dongliang Mu > --- > fs/f2fs/checkpoint.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index f5366feea82d..521498b2dd8c 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -158,7 +158,6 @@ static bool __is_bitmap_valid(struct f2fs_sb_info *sbi, block_t blkaddr, > f2fs_err(sbi, "Inconsistent error blkaddr:%u, sit bitmap:%d", > blkaddr, exist); > set_sbi_flag(sbi, SBI_NEED_FSCK); > - WARN_ON(1); > } > return exist; > } > @@ -196,7 +195,6 @@ bool f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, > f2fs_warn(sbi, "access invalid blkaddr:%u", > blkaddr); > set_sbi_flag(sbi, SBI_NEED_FSCK); > - WARN_ON(1); > return false; > } else { > return __is_bitmap_valid(sbi, blkaddr, type);