From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA67DC761A6 for ; Fri, 31 Mar 2023 16:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233072AbjCaQEq (ORCPT ); Fri, 31 Mar 2023 12:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjCaQEn (ORCPT ); Fri, 31 Mar 2023 12:04:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B10831EFC9 for ; Fri, 31 Mar 2023 09:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680278636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSNZ8/l+VZ86qtadx/3cTwXAVAmwqfzRU1WoIUzmJNE=; b=AWPD+R8Z7Zo+cKE5Rbz7uqtWVIrqftICpfSBT6cXjajmNvqEIl85iA2MbuZWv3hOkXrnYO wIf84z3zN6hF/rCw3jf/+5TKpzeqM7UfKkFlHjM4cqieVcXX7W5/8jl98/mRCv9Ws0gmkf OVuJgcEOczdPfcDnJqaPnlFTy+tSReI= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-7xq3yhjTMdulPo2lV8SAOw-1; Fri, 31 Mar 2023 12:03:55 -0400 X-MC-Unique: 7xq3yhjTMdulPo2lV8SAOw-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-544781e30easo221527887b3.1 for ; Fri, 31 Mar 2023 09:03:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680278635; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSNZ8/l+VZ86qtadx/3cTwXAVAmwqfzRU1WoIUzmJNE=; b=57sCUqO1c4hU1iCtnARwhDqOJBvzMDAYZTlgFD9xqLYn2nNEaHJ4xvfHxzBXGZcifN YiP+eoHVZp3Bq5ibrG61QvgExssc6zRLSTj01zt4+UzkcAFSMjv2HKTQd+xssx5rv7VF /VWFGfwdfCTu9ZUOkEYKBrhRIpCx4JND1VTzuijHEZtBt12HeImrcSHGFXEMFcq0yLoW IOqmSGdzHGHxBDHxLTpch1vMXLjYhqTcrcW1Q1Tvt6yUMckoUEe3NevzbX9yV5TJVFSw 1d5B7zM8ey5z3JRMWoNc7XQhQ0W0QypahM2yG0cMIYovmDfQWlVXrkk31jp83dsJQw+o DOGQ== X-Gm-Message-State: AAQBX9eHZYp8rz56IMilsJPIvlvyPFLAK8Vu7KjNNhWac/qfqPcgnPe5 rOz9T2MpPT4dkVmW6C5LEd/Nonsxgrb6oDyyiv219f4mj4vfGgVyN+m9eSgQxlLfQx8LjJg5+MV KCRZhSyT4ylbeRTeHOeQg8aiU X-Received: by 2002:a05:7500:3e83:b0:fe:c8a6:575 with SMTP id li3-20020a0575003e8300b000fec8a60575mr286783gab.18.1680278634914; Fri, 31 Mar 2023 09:03:54 -0700 (PDT) X-Google-Smtp-Source: AKy350aYLH+nRBLs0BOSrhOyR0e8vNMPADpf6r8qKAygoUTF/7n8384rN6qordhqj3TeCWcFnm7i8Q== X-Received: by 2002:a05:7500:3e83:b0:fe:c8a6:575 with SMTP id li3-20020a0575003e8300b000fec8a60575mr286763gab.18.1680278634565; Fri, 31 Mar 2023 09:03:54 -0700 (PDT) Received: from [192.168.1.12] (pool-68-160-135-240.bstnma.fios.verizon.net. [68.160.135.240]) by smtp.gmail.com with ESMTPSA id y25-20020a37f619000000b0074382b756c2sm760767qkj.14.2023.03.31.09.03.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 09:03:54 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 12:03:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Alexey Dobriyan Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Josh Poimboeuf , Miroslav Benes , Petr Mladek , Marcos Paulo de Souza References: <4ce29654-4e1e-4680-9c25-715823ff5e02@p183> <683593a8-79db-4f3b-bc78-7917284683e4@p183> From: Joe Lawrence Subject: Re: [PATCH v7 00/10] livepatch: klp-convert tool In-Reply-To: <683593a8-79db-4f3b-bc78-7917284683e4@p183> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/23 13:04, Alexey Dobriyan wrote: > This patchset somehow breaks the build of the simplest livepatch module: > > make -f linux/linux-1/scripts/Makefile.modfinal > make[1]: *** No rule to make target 'linux/module-klp/main.tmp.ko', needed by 'linux/module-klp/main.ko'. Stop. > Thanks for testing. Presumably this is an out-of-tree livepatch module? If so, that is still on the TODO list. If not, that is weird as the patchset itself includes updates to samples/ and lib/ livepatches that build and load fine. -- Joe > $ cat Kbuild > obj-m := main.o > > $ cat main.c > #include > #include > #include > #include > > static int livepatch_cmdline_proc_show(struct seq_file *m, void *data) > { > seq_puts(m, "REDACTED 001\n"); > return 0; > } > > static struct klp_func funcs[] = { > { > .old_name = "cmdline_proc_show", > .new_func = livepatch_cmdline_proc_show, > }, > {} > }; > > static struct klp_object objs[] = { > { > .funcs = funcs, > }, > {} > }; > > static struct klp_patch g_patch = { > .mod = THIS_MODULE, > .objs = objs, > }; > > static int livepatch_init(void) > { > return klp_enable_patch(&g_patch); > } > > static void livepatch_exit(void) > { > } > module_init(livepatch_init); > module_exit(livepatch_exit); > MODULE_LICENSE("GPL"); > MODULE_INFO(livepatch, "Y"); >