From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/7] dt-bindings: misc: Add the Lantiq PEF2466 E1/T1/J1 framer
Date: Mon, 20 Mar 2023 11:20:32 +0100 [thread overview]
Message-ID: <f13b06e3-1947-b0f3-6523-d2986f085898@linaro.org> (raw)
In-Reply-To: <20230320104619.468a304b@bootlin.com>
On 20/03/2023 10:46, Herve Codina wrote:
>>
>>> +
>>> + lantiq,data-rate-bps:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + enum: [2048000, 4096000, 8192000, 16384000]
>>> + default: 2048000
>>> + description:
>>> + Data rate (bit per seconds) on the system highway.
>>
>> Why do you need it? How is it different from clock? Do you expect some
>> DDR here?
>
> This is needed to set the data position on the data line.
> If the data line clock (sysclk-rate-hz) is greater than 'data-rate-bps',
> the device interleaves some holes between data in the full frame.
>
> The exact position of the data and the holes is defined by 'channel-phase'
>
> So, two information are needed:
> - The number of slots available (deduced from 'lantiq,data-rate-bps')
> - The slot to use in the available slots ('lantiq,channel-phase" property
>
> lantiq,data-rate-bps is not a clock but a property used to set the frame
> physical setting. ie the correct data position in the frame.
OK
(...)
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/gpio/gpio.h>
>>> + pef2256@2000000 {
>>
>> Figure out some generic node name.
>
> What do you think about 'framer' ?
Sure, I don't have particular proposal.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-20 10:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 12:27 [PATCH v2 0/7] Add the Lantiq PEF2256 audio support Herve Codina
2023-03-16 12:27 ` [PATCH v2 1/7] dt-bindings: misc: Add the Lantiq PEF2466 E1/T1/J1 framer Herve Codina
2023-03-17 8:54 ` Krzysztof Kozlowski
2023-03-20 9:46 ` Herve Codina
2023-03-20 10:20 ` Krzysztof Kozlowski [this message]
[not found] ` <167930560089.26.8624952010101991814@mailman-core.alsa-project.org>
2023-03-20 18:51 ` Rob Herring
2023-03-22 10:20 ` Herve Codina
2023-03-22 12:56 ` Rob Herring
2023-03-22 13:09 ` Rob Herring
2023-03-17 8:55 ` Krzysztof Kozlowski
2023-03-16 12:27 ` [PATCH v2 2/7] drivers: misc: Add support for the Lantiq PEF2256 framer Herve Codina
2023-03-16 12:49 ` Greg Kroah-Hartman
2023-03-16 16:29 ` Herve Codina
2023-03-16 14:00 ` Christophe Leroy
2023-03-17 16:24 ` Herve Codina
2023-03-16 12:27 ` [PATCH v2 3/7] Documentation: sysfs: Document the Lantiq PEF2256 sysfs entry Herve Codina
2023-03-16 12:27 ` [PATCH v2 4/7] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-03-16 12:27 ` [PATCH v2 5/7] dt-bindings: sound: Add support for the Lantiq PEF2256 codec Herve Codina
2023-03-17 8:57 ` Krzysztof Kozlowski
2023-03-20 18:17 ` Herve Codina
2023-03-20 18:21 ` Krzysztof Kozlowski
2023-03-16 12:27 ` [PATCH v2 6/7] ASoC: codecs: " Herve Codina
2023-03-17 18:27 ` Christophe Leroy
2023-03-16 12:27 ` [PATCH v2 7/7] MAINTAINERS: Add the Lantiq PEF2256 ASoC codec entry Herve Codina
2023-03-17 8:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13b06e3-1947-b0f3-6523-d2986f085898@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).